Also clear cache after destroy #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@battlejj Hey, don't merge this yet, it's still not working as expected. Will test it properly tomorrow and update! |
|
@rubenstolk no worries. Do you mind adding whatever tests you come up for the cache portion to the PR as well? |
|
Hi @battlejj Not sure if you like it, but I've rewritten everything to be a bit more 2017 ready:
On top of that I also made the tests run with and without cache |
|
Very happy to have some ES6 updating especially when the features are supported by Node core and don't require a compile step. These changes are a bit more comprehensive so I'll need more time to review them tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@battlejj Thanks for updating the deps, I forgot one more thing...