Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SSG Feature for palpatine: Support --config with JSON file #11

Closed
saminarp opened this issue Oct 1, 2022 · 3 comments
Closed

New SSG Feature for palpatine: Support --config with JSON file #11

saminarp opened this issue Oct 1, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@saminarp
Copy link
Contributor

saminarp commented Oct 1, 2022

Hi,

I would like to add a new feature to Palpatine SSG. Through this new feature, it would be able to support the Config file with the
--config flag.

Here is the list of all that I will implement as specified in the lab 4 instructions.

  1. The -c or --config flags accept a file path to a JSON config file.
  2. If the file is missing, or can't be parsed as JSON, exit with an appropriate error message.
  3. If the -c or --config option is provided, ignore all other options (i.e., a config file overrides other options on the command line).
  4. The program should ignore any options in the config file it doesn't recognize.
  5. If the config file misses any options, assume the usual defaults. For example, use dist/ as the output directory if it isn't specified.

:) I will be reaching out through Slack with questions if any!

@batunpc batunpc added the enhancement New feature or request label Oct 1, 2022
@saminarp
Copy link
Contributor Author

saminarp commented Oct 6, 2022

Hello,

As lab4 requires us to provide config file which is in json format, I need to use the following library nlohmann/json. Could you help me insert this library like the way you did for argaprser and termcolor? Thanks!

@batunpc
Copy link
Owner

batunpc commented Oct 6, 2022

Hi! please see #12

@batunpc batunpc pinned this issue Oct 6, 2022
@batunpc batunpc changed the title New SSG Feature for palpatine: Support --config with Config File New SSG Feature for palpatine: Support --config with JSON file Oct 6, 2022
@batunpc
Copy link
Owner

batunpc commented Oct 7, 2022

Closes: #12

@batunpc batunpc closed this as completed Oct 7, 2022
@batunpc batunpc unpinned this issue Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants