Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config feature initial - discussion #12

Merged
merged 6 commits into from
Oct 7, 2022
Merged

Conversation

saminarp
Copy link
Contributor

@saminarp saminarp commented Oct 6, 2022

Hello,

I just started working on your project. I have a question:

As lab4 requires us to provide config file which is in json format, I need to use the following library nlohmann/json. Could you help me insert this library like the way you did for argparser and termcolor? Thanks!

@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for emperor-palpatine ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/emperor-palpatine/deploys/633f6a6342952d353754f740
😎 Deploy Preview https://deploy-preview-12--emperor-palpatine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@batunpc
Copy link
Owner

batunpc commented Oct 6, 2022

Hello @saminarp

I have just recently updated the repo including the nlohmann/json library for you using CMake. See the commit here Also if you are curious on how to add libraries using CMake, you can read the docs here. Simply project palpatine has a file AddGitSubModule.cmake withing the directory cmake This is a cmake function that lets you add libraries by just typing the following add_git_submodule("external/<libname here>"). (i.e external is the directory I created to keep all this kind of third party libraries)

Good luck let me know if any questions arises!

@batunpc
Copy link
Owner

batunpc commented Oct 6, 2022

Also I am working on the netlify fix, please ignore the checks

@saminarp
Copy link
Contributor Author

saminarp commented Oct 6, 2022

Follow up to your comment above, I am having trouble accessing the nlohmann json library. After further investigating I noticed wrong git submodule has been imported. Could you take a look ?
Thank you

@batunpc
Copy link
Owner

batunpc commented Oct 6, 2022

@saminarp fixed by bf2089a
Please try again

@saminarp saminarp marked this pull request as ready for review October 7, 2022 00:27
@batunpc batunpc merged commit c08c63a into batunpc:main Oct 7, 2022
@saminarp
Copy link
Contributor Author

saminarp commented Oct 7, 2022

thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progres
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants