Reorganize package into submodules #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The supported diagrams are already defined using `Symbol`s in the `LIMITED_DIAGRAM_SUPPORT`. The previous 'string indirection' existed solely due to the macro interpolation not having been completely understood. Ensuring the diagram `type` `Symbol`s are quoted twice removes the need for the string indirection.
This functionality is relatively self-contained meta-progamming, moving it into its own module helps to clearly delineate the metaprogramming from the core functionality of the package.
bauglir
force-pushed
the
reorganize-package
branch
from
837970d
to
b73c273
Compare
Codecov Report
@@ Coverage Diff @@
## development #15 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 2 4 +2
Lines 92 92
=============================================
Hits 92 92
Continue to review full report at Codecov.
|
Exceptions require some boilerplate to render nicely and obstruct the flow of the definition of the main functionality of the package. Extracting them into a separate module decreases the amount of code necessary to grasp the core concepts of the package in both the package itself as well as its tests.
bauglir
force-pushed
the
reorganize-package
branch
from
b73c273
to
c43c9e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main package module is slowly becoming more of a nuisance to navigate/keep an overview of and the tests take increasingly longer having to run them all. By splitting functionality up into dedicated
modules, it's both easier to keep an overview of the package and to run subsets of tests during development by commenting certainincludes out.