Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop testing on nightly #9

Merged
merged 1 commit into from Jun 23, 2022
Merged

Stop testing on nightly #9

merged 1 commit into from Jun 23, 2022

Conversation

bauglir
Copy link
Owner

@bauglir bauglir commented Jun 23, 2022

SimpleMock appears to have issues with nightly versions of Julia due to its dependency on Cassette, see JuliaTesting/SimpleMock#13. This is causing failures in CI, e.g.https://github.com/bauglir/Kroki.jl/runs/7020848187#step:5:82.

Given that most people will likely be using this package on stable releases anyway and the pace at which this package evolves, there doesn't seem to be too much gain in testing on nightly to begin with.

`SimpleMock` appears to have issues with nightly versions of Julia due
to its dependency on Cassette, see JuliaTesting/SimpleMock#13. This is
causing failures in CI, e.g.
https://github.com/bauglir/Kroki.jl/runs/7020848187#step:5:82.

Given that most people will likely be using this package on stable
releases anyway and the pace at which this packages evolves, there
doesn't seem to be too much gain in testing on nightly to begin with.
@bauglir bauglir self-assigned this Jun 23, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #9 (158e425) into development (3f8c575) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           development        #9   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files                2         2           
  Lines               74        74           
=============================================
  Hits                74        74           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f8c575...158e425. Read the comment docs.

@bauglir bauglir added the bug Something isn't working label Jun 23, 2022
@bauglir bauglir merged commit acae594 into development Jun 23, 2022
@bauglir bauglir deleted the stop-testing-on-nightly branch June 23, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant