fix: prevent double adding of assets

This happened when assets where rendered manually via ->render()
baumrock · Jun 7, 2023 · 14b9b10 · 14b9b10
1 parent fc3d1ae
commit 14b9b10
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/classes/AssetsArray.php b/classes/AssetsArray.php
@@ -13,7 +13,7 @@ class AssetsArray extends \ProcessWire\WireArray
   public $minify = false;
   public $name;
   public $noNewLine = false;
-
+  public $rendered = false;
 
   public function __construct(string $name)
   {

diff --git a/classes/ScriptsArray.php b/classes/ScriptsArray.php
@@ -9,6 +9,9 @@ class ScriptsArray extends AssetsArray
 
   public function render($options = [])
   {
+    if ($this->rendered) return;
+    $this->rendered = true;
+
     if (is_string($options)) $options = ['indent' => $options];
 
     // setup options

diff --git a/classes/StylesArray.php b/classes/StylesArray.php
@@ -186,6 +186,9 @@ public function postCSS($asset)
 
   public function render($options = [])
   {
+    if ($this->rendered) return;
+    $this->rendered = true;
+
     if (is_string($options)) $options = ['indent' => $options];
 
     // setup options