fix: don't create manifest by default

baumrock · Jan 28, 2024 · 1b17b86 · 1b17b86
1 parent 15ad6cf
commit 1b17b86
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 17 deletions.
diff --git a/RockFrontend.module.php b/RockFrontend.module.php
@@ -73,6 +73,8 @@ class RockFrontend extends WireData implements Module, ConfigurableModule
   public $autoloadScripts;
   public $autoloadStyles;
 
+  public $createManifest = false;
+
   /** @var WireArray $folders */
   public $folders;
 
@@ -2094,8 +2096,10 @@ public function rm()
   /**
    * @return Seo
    */
-  public function seo()
-  {
+  public function seo(
+    bool $createManifest = false,
+  ) {
+    $this->createManifest = $createManifest;
     if ($this->seo) return $this->seo;
     require_once __DIR__ . "/Seo.php";
     return $this->seo = new Seo();

diff --git a/Seo.php b/Seo.php
@@ -12,7 +12,6 @@
 
 class Seo extends Wire
 {
-
   /** @var array */
   protected $rawValues;
 
@@ -369,19 +368,21 @@ public function ___setupDefaults()
     });
 
     // webmanifest
-    $this->setMarkup('manifest', '<link rel="manifest" href="{value}">');
-    $this->setValue('manifest', function () {
-      /** @var RockFrontend $rf */
-      $rf = $this->wire->modules->get('RockFrontend');
-      $manifest = $rf->manifest();
-      return $manifest->url();
-    });
-    $this->setMarkup('theme-color', '<meta name="theme-color" content="{value}">');
-    $this->setValue('theme-color', function () {
-      /** @var RockFrontend $rf */
-      $rf = $this->wire->modules->get('RockFrontend');
-      return $rf->manifest()->themeColor;
-    });
+    if ($this->rockfrontend()->createManifest) {
+      $this->setMarkup('manifest', '<link rel="manifest" href="{value}">');
+      $this->setValue('manifest', function () {
+        /** @var RockFrontend $rf */
+        $rf = $this->wire->modules->get('RockFrontend');
+        $manifest = $rf->manifest();
+        return $manifest->url();
+      });
+      $this->setMarkup('theme-color', '<meta name="theme-color" content="{value}">');
+      $this->setValue('theme-color', function () {
+        /** @var RockFrontend $rf */
+        $rf = $this->wire->modules->get('RockFrontend');
+        return $rf->manifest()->themeColor;
+      });
+    }
   }
 
   /**

diff --git a/profiles/rockpagebuilder/files/site/templates/_init.php b/profiles/rockpagebuilder/files/site/templates/_init.php
@@ -2,6 +2,8 @@
 
 namespace ProcessWire;
 
+/** @var RockFrontend $rockfrontend */
+
 $htmlLang = "de";
 
 $rockfrontend->styles()
@@ -15,5 +17,5 @@
   ->add('/site/templates/scripts/main.js', 'defer')
   ->minify(!$config->debug);
 
-$seo = $rockfrontend->seo()
+$seo = $rockfrontend->seo(createManifest: false)
   ->title($page->title . " | example.com");