feat: don't load livereload in iframes and update minification

baumrock · Jul 4, 2023 · 75e6699 · 75e6699
1 parent 82957c0
commit 75e6699
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/RockFrontend.module.php b/RockFrontend.module.php
@@ -350,7 +350,8 @@ private function addLiveReloadScript()
   {
     // we only add live reloading to the frontend
     if ($this->wire->page->template == 'admin') return;
-    $this->scripts('rockfrontend')->add($this->path . "livereload.min.js", "defer");
+    $file = $this->minifyFile($this->path . "livereload.js");
+    $this->scripts('rockfrontend')->add($file, "defer");
   }
 
   /**

diff --git a/livereload.js b/livereload.js
@@ -6,6 +6,9 @@ setTimeout(() => {
   if (isModal) return;
   let reloading = false;
 
+  // dont load in iframes
+  if (window.self !== window.top) return;
+
   // timeout after file change was detected
   // you can set this to 5000 if you see multiple redirects
   // that means that something triggers another reload on reload

diff --git a/livereload.min.js b/livereload.min.js