Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(request:MagicPages module) Make attachment of magic field methods optional #59

Closed
netcarver opened this issue Apr 21, 2024 · 4 comments

Comments

@netcarver
Copy link

Whilst I understand this is useful to you, would you consider making this feature of MagicPages optional via a $config->rockMigrations setting?

Very happy for it to default to attaching the methods - but this is one aspect I'd like to be able to control on my installs. Wouldn't even need to be a configurable module setting, just something in site/config.php would do.

@BernhardBaumrock
Copy link
Member

done, thx

@netcarver
Copy link
Author

@BernhardBaumrock Perfect, thank you.

@MrSnoozles
Copy link

MrSnoozles commented May 28, 2024

Thanks for the request and the implementation. I'm still using older versions of RockMigrations because right now it's doing too much for my setups. This helps 👍
Maybe all the magic utilities, backend hooks and watchers could even be split into a separate module for people that just want to use $rm->doSomething() from the CI and have the main module as slim as possible?

@BernhardBaumrock
Copy link
Member

This would mean a lot of work and refactoring on all my projects, as you can imagine. Do you want to sponsor this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants