Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed tool requires that python be the correct executable #6

Open
danielhoherd opened this issue Jan 13, 2020 · 1 comment
Open

Comments

@danielhoherd
Copy link

danielhoherd commented Jan 13, 2020

Description

pip install flameprof requires that python be the correct version of the executable. For those of us running python3 where python still points to python2, this causes a problem.

Steps to reproduce

  1. On macOS 10.15 running python3 from homebrew, run pip3 install --user flameprof
  2. $ cat $(which flameprof) will output:
    #!/bin/sh
    exec python -m flameprof "$@"
    
  3. python --version will output Python 2.7.17

Proposed solution

The first way I can think of to solve this is to write the contents of flameprof with an explicit version numbered interpreter, IE: python2 or python3, as determined by the version running when installed. That seems fragile, but less fragile than what exists today.

This was referenced Mar 2, 2020
@danielhoherd danielhoherd reopened this Mar 2, 2020
@danielhoherd
Copy link
Author

This is solved by #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant