Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Adding an Extra column to the transfer table #865

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

rez1dent3
Copy link
Member

@rez1dent3 rez1dent3 commented Jan 24, 2024

#864

Example 1:

        $transfers = $transferQueryHandler->apply([
            new TransferQuery(
                $from,
                $to,
                100,
                new Extra(
                    null,
                    null,
                    '598c184c-e6d6-4fc2-9640-c1c7acb38093',
                    ['type' => 'first'],
                ),
            ),
        ]);

Example 2:

        $transfer = $user1->transfer(
            $user2,
            500,
            new Extra(
                deposit: [
                    'type' => 'extra-deposit',
                ],
                withdraw: new Option(
                    [
                        'type' => 'extra-withdraw',
                    ],
                    false
                ),
                extra: ['msg' => 'hello world'],
            )
        );

@rez1dent3 rez1dent3 self-assigned this Jan 24, 2024
@rez1dent3 rez1dent3 linked an issue Jan 24, 2024 that may be closed by this pull request
Copy link

cloudflare-pages bot commented Jan 24, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 12151a7
Status: ✅  Deploy successful!
Preview URL: https://e398438c.laravel-wallet.pages.dev
Branch Preview URL: https://864-can-a-new-field-be-added.laravel-wallet.pages.dev

View logs

Copy link

github-actions bot commented Jan 24, 2024

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a0f9c6) 100.00% compared to head (12151a7) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #865   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       559       567    +8     
===========================================
  Files             86        86           
  Lines           1964      1997   +33     
===========================================
+ Hits            1964      1997   +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rez1dent3 rez1dent3 merged commit 8f57694 into master Jan 24, 2024
77 checks passed
@rez1dent3 rez1dent3 deleted the 864-can-a-new-field-be-added-to-the-transfer-table branch January 25, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can a new field be added to the transfer table?
1 participant