-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all data types #12
Conversation
Thank you for your kind contribution! @wallento Ok if I let you review this one? I'm assuming you have a better notion of the impact of this change. |
yes, I will review it. Unfortunately it seems we are hitting another bug in travis, which is related to this: lowRISC/ibex#24 I will soon fix that one. Anyhow, this one looks good. Thanks a lot! |
What does this mean specifically for the wavedrompy version requirement? |
There are a few minor things to add (not in the waveform part, but the bit fields) before I will release 1.9.0. We should bump it then. |
Cool. I'll try to help a bit with wavedrompy capabilities as well. |
Thanks. As you probably saw, I rewrote the main parsing part to be more pythonic. This fixes a ton of issues I found with the upstream wavedrom code when it comes to subcycles. I added regression tests and hope to find some time to also put fixes/bug reports to upstream. Cheers, |
Created #13 in order to track the issue of the failing CI. Will merge this one as is, but will need a passing CI to actually release to pypi. |
This is an example of how to address issue #11. Using wavedrom.render() probably merits moving the setup.py requires line forward as well.
This along with wavedrom=1.9.0rc1 allows me to build the example doc for both html and latexpdf targets with WAVEDROM_HTML_NOJSINLINE=1.