Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all data types #12

Merged
merged 2 commits into from
May 14, 2019
Merged

Conversation

joshuascheid
Copy link
Contributor

This is an example of how to address issue #11. Using wavedrom.render() probably merits moving the setup.py requires line forward as well.

This along with wavedrom=1.9.0rc1 allows me to build the example doc for both html and latexpdf targets with WAVEDROM_HTML_NOJSINLINE=1.

@bavovanachte
Copy link
Owner

bavovanachte commented May 13, 2019

Thank you for your kind contribution!

@wallento Ok if I let you review this one? I'm assuming you have a better notion of the impact of this change.

@wallento
Copy link
Collaborator

yes, I will review it. Unfortunately it seems we are hitting another bug in travis, which is related to this: lowRISC/ibex#24 I will soon fix that one.

Anyhow, this one looks good. Thanks a lot!

@bavovanachte
Copy link
Owner

What does this mean specifically for the wavedrompy version requirement?

@wallento
Copy link
Collaborator

There are a few minor things to add (not in the waveform part, but the bit fields) before I will release 1.9.0. We should bump it then.

@joshuascheid
Copy link
Contributor Author

Cool. I'll try to help a bit with wavedrompy capabilities as well.

@wallento
Copy link
Collaborator

Thanks. As you probably saw, I rewrote the main parsing part to be more pythonic. This fixes a ton of issues I found with the upstream wavedrom code when it comes to subcycles. I added regression tests and hope to find some time to also put fixes/bug reports to upstream.

Cheers,
Stefan

@bavovanachte
Copy link
Owner

Created #13 in order to track the issue of the failing CI. Will merge this one as is, but will need a passing CI to actually release to pypi.

@bavovanachte bavovanachte merged commit 06f3682 into bavovanachte:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants