Skip to content

Commit

Permalink
test: make test apps' name prefixed with electron-test- (electron#33511)
Browse files Browse the repository at this point in the history
  • Loading branch information
zcbenz authored and bavulapati committed Apr 29, 2022
1 parent 558e5cf commit 3c639a1
Show file tree
Hide file tree
Showing 23 changed files with 26 additions and 50 deletions.
8 changes: 4 additions & 4 deletions spec-main/api-app-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ describe('app module', () => {

it('overrides the name', () => {
expect(app.name).to.equal('Electron Test Main');
app.name = 'test-name';
app.name = 'electron-test-name';

expect(app.name).to.equal('test-name');
expect(app.name).to.equal('electron-test-name');
app.name = 'Electron Test Main';
});
});
Expand All @@ -104,9 +104,9 @@ describe('app module', () => {

it('overrides the name', () => {
expect(app.getName()).to.equal('Electron Test Main');
app.setName('test-name');
app.setName('electron-test-name');

expect(app.getName()).to.equal('test-name');
expect(app.getName()).to.equal('electron-test-name');
app.setName('Electron Test Main');
});
});
Expand Down
2 changes: 1 addition & 1 deletion spec-main/api-session-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1130,7 +1130,7 @@ describe('session module', () => {
session.defaultSession.setCodeCachePath('');
}).to.throw('Absolute path must be provided to store code cache.');
expect(() => {
session.defaultSession.setCodeCachePath(path.join(app.getPath('userData'), 'test-code-cache'));
session.defaultSession.setCodeCachePath(path.join(app.getPath('userData'), 'electron-test-code-cache'));
}).to.not.throw();
});
});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "context-bridge-mutability",
"name": "electron-test-context-bridge-mutability",
"main": "main.js"
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "electron-safe-storage",
"name": "electron-test-safe-storage",
"main": "main.js"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "electron-safe-storage",
"name": "electron-test-safe-storage",
"main": "main.js"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "background-color-transparent",
"name": "electron-test-background-color-transparent",
"main": "main.js"
}
4 changes: 2 additions & 2 deletions spec-main/fixtures/apps/xwindow-icon/package.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "electron-xwindow-icon",
"name": "electron-test-xwindow-icon",
"main": "main.js"
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "electron-test-initial-app",
"name": "electron-test-check-with-headers",
"version": "1.0.0",
"main": "./index.js"
}
}
4 changes: 2 additions & 2 deletions spec-main/fixtures/auto-update/check/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "electron-test-initial-app",
"name": "electron-test-check",
"version": "1.0.0",
"main": "./index.js"
}
}
4 changes: 2 additions & 2 deletions spec-main/fixtures/auto-update/update-json/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "initial-app",
"name": "electron-test-update-json",
"version": "1.0.0",
"main": "./index.js"
}
}
4 changes: 2 additions & 2 deletions spec-main/fixtures/auto-update/update/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "initial-app",
"name": "electron-test-update",
"version": "1.0.0",
"main": "./index.js"
}
}
2 changes: 1 addition & 1 deletion spec/fixtures/api/cookie-app/package.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "electron-cookie-app",
"name": "electron-test-cookie-app",
"main": "main.js"
}
1 change: 0 additions & 1 deletion spec/fixtures/api/electron-module-app/.gitignore

This file was deleted.

14 changes: 0 additions & 14 deletions spec/fixtures/api/electron-module-app/index.html

This file was deleted.

Empty file.

This file was deleted.

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion spec/fixtures/api/mixed-sandbox-app/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "electron-app-mixed-sandbox",
"name": "electron-test-mixed-sandbox",
"main": "main.js"
}

2 changes: 1 addition & 1 deletion spec/fixtures/api/quit-app/package.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"name": "electron-quit-app",
"name": "electron-test-quit-app",
"main": "main.js"
}
2 changes: 1 addition & 1 deletion spec/fixtures/api/relaunch/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "electron-app-relaunch",
"name": "electron-test-relaunch",
"main": "main.js"
}

2 changes: 1 addition & 1 deletion spec/fixtures/api/singleton-data/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "electron-app-singleton-data",
"name": "electron-test-singleton-data",
"main": "main.js"
}

2 changes: 1 addition & 1 deletion spec/fixtures/api/singleton/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "electron-app-singleton",
"name": "electron-test-singleton",
"main": "main.js"
}

0 comments on commit 3c639a1

Please sign in to comment.