Inconsistent results.

[logicethos]

gains-calculator-version1.py

days: £ 846.84
b&b £ 66.27
Ave £ 33724.97
Fees GBP: £ 204.47
Total Capital Gains for 2016 / 2017 : £ 34433.61

Put the html report into a spreadsheet, and add up the columns:

days: £ 846.84
b&b £ -2887.94
Ave £ 33725.05
Fees GBP: ?
Total Capital Gains for 2016 / 2017 : £ 31684

gains-calculator-version2.py

day gains 846.8395430421293
bnb gains -2887.922476344005
average gains 31461.512091758214
TOTAL GAINS: 29420.429158456336

[logicethos]

My 2018 calculation is much more consistent.

[baxter100]

I've just updated the append_detailed_list(self,x,y) function as I think it may have been gifts that were causing the problem and I realized the function wasn't dealing properly with this situation.

Does v1 now remove the inconsistencies? The new html report should be slightly different in the gain/loss column

[logicethos]

So if I put the HTML output into a spreadsheet again, and total the columns, I now get

days: £ 846.84
b&b £ -1363.64
Ave £ 33725.05
Total Capital Gains for 2016 / 2017 : £ 33208.3

So a different b&b and TotalCG from last time, and not the same as v2.

The summery text says (note the b&b figure):

Gain from days: £846.84. Gain from bed and breakfasting: £66.27. Gain from 404 Holdings: £33724.97 Total value of fees paid in GBP: £0 Total Capital Gains for 2016/2017: £34638.08
Total Taxable Gain for 2016/2017 for 'normal' people: £23538.08
Total tax owed at 20.0% tax rate: £4707.616

If you need data, that's not a problem. Contact me privately. And i am happy to pay for your time.
Thanks.

[baxter100]

If you send me a private message on reddit with the trade list you are using that could help to resolve this

[baxter100]

I'm struggling to pin down the exact problem but after playing around for a couple of hours I believe the problem is because of the large spreads. When I first began writing it I was under the assumption that the Buy Value in GBP would always be roughly the same as the Sell Value in GBP, so I didn't consider it much and then just fixed things post-hoc as they arose.

I think the problem is likely occurring because at various stages different values are used for the value of the sale. I need to look into it more/make it more rigorous and tidy it up when I have some time. I'll get back to you when I can

[logicethos]

Thank you. I would have liked to have had a go at writing my own calculator, but it's quite involved isn't it. I am busy working on a blockchain startup for the next few months, and I'm more of a C# coder to be able to debug python successfully. So it's much appreciated.

[logicethos]

I decided to have a go at writing my own calculator. It highlighted an issue with fees in my original figures. Fees are baked into the trades, so care needs to be taken when importing into CoinTracking.

I'm still getting very different results however.
To help debug and find possible issues, I found it helpful to do FIFO on the 104Holding, and keep a running total on each coin. If anything fell out of range, it would either throw an exception or put a warning in the summary.