Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position error on windows 10 #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dabeibao
Copy link

@dabeibao dabeibao commented Sep 2, 2023

In windows 10, there is a invisible borders.
When window's position is set to (0, 0), there will be some gap between screen left border and game window left border.

This commit fix the issue with solution provided in: https://stackoverflow.com/a/34143777/1277762

@dabeibao
Copy link
Author

dabeibao commented Sep 2, 2023

When I set position to (0, 0),
before this commit, the position is (see the gap in red circle):
before

After the commit,
image

@dabeibao
Copy link
Author

dabeibao commented Sep 2, 2023

Also if not full screen mode, I suggest to set the working rect as monitor_info.rcWork, instead of the rcMonitor in line 343.

Since it is not full screen mode, seems it is better not overlap taskbar.

In windows 10, there is a invisible borders.
When window's position is set to (0, 0), there will be some gap
between screen left border and game window left border.

This commit fix the issue with solution provided in:
https://stackoverflow.com/a/34143777/1277762
@weili0677
Copy link

大佬牛b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants