Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the unit test for
FlorisInterface.calculate_no_wake
in favor of a similar test structured as a regression test.The unit test essentially replicated the functionality within the code it was testing and ensured that the results were the same. While this is worthwhile, it can be cumbersome to have the same functionality repeated twice since any change will have to occur in two places. Also, this type of test checks for stability as a function of time (or commits) rather than correctness. This is generally more practical to structure as a regression test since we can simply run the tested code and compare to outputs. A change in the tested code will not necessarily require a change in the test. Furthermore, structuring this as a regression test allows to build additional tests in a similar manner without repeating the implementation of the tested code.