Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fi test #7

Merged
Merged

Conversation

rafmudaf
Copy link

@rafmudaf rafmudaf commented Mar 3, 2023

This pull request removes the unit test for FlorisInterface.calculate_no_wake in favor of a similar test structured as a regression test.

The unit test essentially replicated the functionality within the code it was testing and ensured that the results were the same. While this is worthwhile, it can be cumbersome to have the same functionality repeated twice since any change will have to occur in two places. Also, this type of test checks for stability as a function of time (or commits) rather than correctness. This is generally more practical to structure as a regression test since we can simply run the tested code and compare to outputs. A change in the tested code will not necessarily require a change in the test. Furthermore, structuring this as a regression test allows to build additional tests in a similar manner without repeating the implementation of the tested code.

@rafmudaf
Copy link
Author

rafmudaf commented Mar 3, 2023

Note that this depends on NREL#599. In that one, I've restructured the regression tests to use a 3x3 grid because the test included here has to go through the FlorisInterface, and FlorisInterface caps the grid size to 3 x 3.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (bugfix/sorting_TIs_with_calculate_no_wake@1d84538). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@                             Coverage Diff                              @@
##             bugfix/sorting_TIs_with_calculate_no_wake       #7   +/-   ##
============================================================================
  Coverage                                             ?   24.55%           
============================================================================
  Files                                                ?       90           
  Lines                                                ?     7440           
  Branches                                             ?        0           
============================================================================
  Hits                                                 ?     1827           
  Misses                                               ?     5613           
  Partials                                             ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bayc bayc merged commit ade0a1a into bayc:bugfix/sorting_TIs_with_calculate_no_wake Mar 6, 2023
@rafmudaf rafmudaf deleted the fi_test branch March 7, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants