Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SDL2 CMakeLists.txt #20

Closed
wants to merge 2 commits into from
Closed

Added SDL2 CMakeLists.txt #20

wants to merge 2 commits into from

Conversation

odrevet
Copy link

@odrevet odrevet commented Nov 3, 2015

The SDL2 example can be build with this CMake configuration file

@baylej
Copy link
Owner

baylej commented Nov 4, 2015

Hi @odrevet, thank you for your contribution.

My thoughts:

  • You should use find_program to locate sdl2-config.
  • Your reference to SDL2_image is constant and hence not portable.
  • As sdl2-config does not provide us with the location of SDL_image, we need a FindSDL_image.cmake script.

Most SDL2 projects using cmake have their own FindSDL2.cmake script, but this will no longer be needed since bug 2464 has been fixed.

Every SDL plugins (SDL2_image included) still do not provide downstream projects with exported cmake targets (they don't even have a CMakeLists.txt). This is more problematic...

@baylej baylej closed this Dec 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants