tmx_utils: Check map->ts_head is non NULL #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang analyze reports a possible NULL pointer dereference if mk_map_tile_array is called with map->ts_head equal to NULL. The offending line is max_ts->image, where max_ts is set to NULL after ts = max_ts = map->ts_head. Adding a trivial check makes Clang analyze happy.
|
This is indeed possible for a map to have no tileset, hence such sort of map is not erroneous, LibTMX should be able to load such map and not return an error. |
|
Well LibTMX currently segfaults for me if I try to open a map with no tileset. This PR stops the crash but returns an error. If you would like to open such a map without error, that would be a bit more work. I could open an issue if you would prefer. |
|
Fixed by 5ae84d9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang analyze reports a possible NULL pointer dereference if
mk_map_tile_array is called with map->ts_head equal to NULL.
The offending line is max_ts->image, where max_ts is set to NULL
after ts = max_ts = map->ts_head. Adding a trivial check makes
Clang analyze happy.