Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert errors with 'Multiple node elments can't be created' #81

Closed
tomaustin700 opened this issue Mar 16, 2018 · 8 comments
Closed

Convert errors with 'Multiple node elments can't be created' #81

tomaustin700 opened this issue Mar 16, 2018 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@tomaustin700
Copy link

Report issue

Hi,
When running Convert on a string I am getting a unhandled exception stating 'Multiple node elments can't be created'. I have attached a sample solution demonstrating this issue.

Expected behavior

Convert does not crash.

Actual Behaviour

Throws unhandled System.Exception: 'Multiple node elments can't be created'

Steps to reproduce the problem

To duplicate just run the solution and it will crash when converting.

Html2MarkdownBugTest.zip

@baynezy baynezy added bug Something isn't working awaiting review This pull request is awaiting review labels Mar 16, 2018
baynezy added a commit that referenced this issue Mar 22, 2018
Issue #81 was added but it cannot be replicated.

Closes #81
@ghost ghost assigned baynezy Mar 22, 2018
@ghost ghost added the in progress label Mar 22, 2018
@baynezy
Copy link
Owner

baynezy commented Mar 22, 2018

@tomaustin700 - I have added a test to show this is not actually a bug in this library. f417907

You can see the test results to prove that.

The error in your attached project occurs in HtmlAgilityPack. I believe this is because you have incorrectly used the latest version whereas Html2Markdown depends on 1.5.0. NuGet should have installed that version when you installed Html2Markdown.

This project will never upgrade HtmlAgilityPack because of zzzprojects/html-agility-pack#74 instead we will upgrade to AngleSharp in the next major version when #68 is completed.

@baynezy baynezy added next release Completed work that is yet to be deployed and removed in progress awaiting review This pull request is awaiting review labels Mar 22, 2018
@tomaustin700
Copy link
Author

@baynezy Changing HtmlAgilityPack to 1.5.0 does seem to resolve this. Thanks.

@ghost ghost removed the next release Completed work that is yet to be deployed label Mar 26, 2018
@mitchavines
Copy link

Hello,

I'm getting this error on anything I try to convert though I have tried both HtmlAgilityPack 1.5.0 and 1.5.5... I'm clearly missing a beat, help please?

@baynezy
Copy link
Owner

baynezy commented Feb 22, 2019

@mitchavines do you have reproduceable case you can link to?

@mitchavines
Copy link

mitchavines commented Feb 22, 2019 via email

@Kellen-Stuart
Copy link

@tomaustin700 - I have added a test to show this is not actually a bug in this library. f417907

You can see the test results to prove that.

The error in your attached project occurs in HtmlAgilityPack. I believe this is because you have incorrectly used the latest version whereas Html2Markdown depends on 1.5.0. NuGet should have installed that version when you installed Html2Markdown.

This project will never upgrade HtmlAgilityPack because of zzzprojects/html-agility-pack#74 instead we will upgrade to AngleSharp in the next major version when #68 is completed.

You are absolutely right. I believe I upgraded the Html Agility Pack and this ended up breaking HTML2Markdown. When I removed both packages, and reinstalled HTML2Markdown, it came by default with Html Agility Pack 1.5.0

@makarandkeer
Copy link

I am also getting same error.
Where can I get HAP 1.5.0, as per https://www.nuget.org/packages/HtmlAgilityPack/ latest version is 1.11.23 https://www.nuget.org/packages/HtmlAgilityPack/1.11.23?

@baynezy
Copy link
Owner

baynezy commented Apr 22, 2020

NuGet has all previous versions https://www.nuget.org/packages/HtmlAgilityPack/1.5.0

baynezy added a commit that referenced this issue Nov 18, 2021
Had to fix some issues with the logic in HAP as it
has changed.

Fixes #81
Fixes #117
baynezy added a commit that referenced this issue Nov 18, 2021
Had to fix some issues with the logic in HAP as it
has changed.

Fixes #81
Fixes #117
Closes #119
baynezy added a commit that referenced this issue Nov 18, 2021
Had to fix some issues with the logic in HAP as it
has changed.

Fixes #81
Fixes #117
Closes #119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants