Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown generation breaks with updated HtmlAgilityPack #117

Closed
sake402 opened this issue Nov 15, 2021 · 2 comments
Closed

Markdown generation breaks with updated HtmlAgilityPack #117

sake402 opened this issue Nov 15, 2021 · 2 comments
Labels
request A request for a new feature or enhancement wontfix The project maintainers have decided this will not be worked on

Comments

@sake402
Copy link

sake402 commented Nov 15, 2021

Report issue

I have a project that already has dependency on HtmlAgilityPack 1.11.38, while HtmlMarkdown depends on 1.5.0

Now with the code below

var converter = new Converter();
converter.Convert("<p><span>A</span>B<span>C</span></p>");

It works if I use HtmlAgilityPack 1.5.0 but throws exception with version 1.11.38 System.Exception: 'Multiple node elements can't be created.' from HtmlAgilityPack

The offending line is

var markdownNode = HtmlNode.CreateNode(markdown);
with markdown "\r\n\r\n<span>A</span>B<span>C</span>\r\n"

Could this be why the HtmlAgilityPack is not updated?

@baynezy
Copy link
Owner

baynezy commented Nov 16, 2021

The reason HtmlAgilityPack has not been updated is because of zzzprojects/html-agility-pack#74 (comment)

I cannot work with a library that cares so little for its consumers. #68 is the solution. I'm just not in a position to resolve that currently.

@baynezy baynezy added wontfix The project maintainers have decided this will not be worked on request A request for a new feature or enhancement labels Nov 16, 2021
@baynezy baynezy closed this as completed Nov 16, 2021
baynezy added a commit that referenced this issue Nov 18, 2021
Had to fix some issues with the logic in HAP as it
has changed.

Fixes #81
Fixes #117
baynezy added a commit that referenced this issue Nov 18, 2021
Had to fix some issues with the logic in HAP as it
has changed.

Fixes #81
Fixes #117
Closes #119
@baynezy
Copy link
Owner

baynezy commented Nov 18, 2021

@sake402 - I have looked at the changes required and I am going to resolve this in #119

baynezy added a commit that referenced this issue Nov 18, 2021
Had to fix some issues with the logic in HAP as it
has changed.

Fixes #81
Fixes #117
Closes #119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request A request for a new feature or enhancement wontfix The project maintainers have decided this will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants