Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and add authentication support #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

markliggett
Copy link

  • Update all dependencies (including the mongodb driver) to the latest versions
  • Deprecate old Mongo implementation options but don't prevent them from being used
  • Add ability to use MongoCredential to support optional authentication
  • Bump major version from 4 to 5
  • Add usage example to readme

@markliggett markliggett changed the title Update dependency versions and add authentication support Update dependencies and add authentication support Jan 29, 2021
@markliggett
Copy link
Author

Sorry @mgoodnow - I just realized I forgot to ping you on this PR 😞

No panic on this at all. Any and all input welcome!

Copy link

@mgoodnow mgoodnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see anything major ...looks great! 👍
Actually, I'm a little surprised it didn't require more changes ...like changes to MongoDBObject !?

Other thoughts, I'm sure you'll know if you are compatible with Dimsum/Pacman/Rosetta by choosing to upgrade to Spring 5 and Guava 30. :)
...as I know it's particularly hard to upgrade confighub sources, as they relay on other teams libraries. :(

Cheers! 💯

.build();

private String applicationName = DEFAULT_MONGO_OPTIONS.getApplicationName();
private List<com.mongodb.MongoCompressor> compressorList = DEFAULT_MONGO_OPTIONS.getCompressorList();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR: Doesn't need to be absolute package path.

private DBEncoderFactory dbEncoderFactory = DEFAULT_MONGO_OPTIONS.getDbEncoderFactory();
private boolean cursorFinalizerEnabled = DEFAULT_MONGO_OPTIONS.isCursorFinalizerEnabled();
private List<com.mongodb.event.ClusterListener> clusterListeners = DEFAULT_MONGO_OPTIONS.getClusterListeners();
private List<com.mongodb.event.CommandListener> commandListeners = DEFAULT_MONGO_OPTIONS.getCommandListeners();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR: Doesn't need to be absolute package path.

@@ -7,20 +7,27 @@
<groupId>com.bazaarvoice.commons</groupId>
<artifactId>bv-opensource-super-pom</artifactId>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMMENT: It might be unnecessary to continue to try to maintain this as an open source library. Although, if you are familiar with releasing it as open source then I guess there is no harm. But honestly, I don't think anyone outside BV is using it.

@@ -51,7 +51,7 @@
<!-- Data -->
<dependency>
<groupId>org.mongodb</groupId>
<artifactId>mongo-java-driver</artifactId>
<artifactId>mongodb-driver-legacy</artifactId>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMMENT: I'm glad to see there are still supporting older applications. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants