Update dependencies and add authentication support #12
Conversation
markliggett
commented
Jan 29, 2021
markliggett
commented
- Update all dependencies (including the mongodb driver) to the latest versions
- Deprecate old Mongo implementation options but don't prevent them from being used
- Add ability to use MongoCredential to support optional authentication
- Bump major version from 4 to 5
- Add usage example to readme
…tial into the client
markliggett
changed the title
|
Sorry @mgoodnow - I just realized I forgot to ping you on this PR 😞 No panic on this at all. Any and all input welcome! |
There was a problem hiding this comment.
Don't see anything major ...looks great! 👍
Actually, I'm a little surprised it didn't require more changes ...like changes to MongoDBObject !?
Other thoughts, I'm sure you'll know if you are compatible with Dimsum/Pacman/Rosetta by choosing to upgrade to Spring 5 and Guava 30. :)
...as I know it's particularly hard to upgrade confighub sources, as they relay on other teams libraries. :(
Cheers! 💯
| .build(); | ||
|
|
||
| private String applicationName = DEFAULT_MONGO_OPTIONS.getApplicationName(); | ||
| private List<com.mongodb.MongoCompressor> compressorList = DEFAULT_MONGO_OPTIONS.getCompressorList(); |
There was a problem hiding this comment.
MINOR: Doesn't need to be absolute package path.
| private DBEncoderFactory dbEncoderFactory = DEFAULT_MONGO_OPTIONS.getDbEncoderFactory(); | ||
| private boolean cursorFinalizerEnabled = DEFAULT_MONGO_OPTIONS.isCursorFinalizerEnabled(); | ||
| private List<com.mongodb.event.ClusterListener> clusterListeners = DEFAULT_MONGO_OPTIONS.getClusterListeners(); | ||
| private List<com.mongodb.event.CommandListener> commandListeners = DEFAULT_MONGO_OPTIONS.getCommandListeners(); |
There was a problem hiding this comment.
MINOR: Doesn't need to be absolute package path.
| @@ -7,20 +7,27 @@ | |||
| <groupId>com.bazaarvoice.commons</groupId> | |||
| <artifactId>bv-opensource-super-pom</artifactId> | |||
There was a problem hiding this comment.
COMMENT: It might be unnecessary to continue to try to maintain this as an open source library. Although, if you are familiar with releasing it as open source then I guess there is no harm. But honestly, I don't think anyone outside BV is using it.
| @@ -51,7 +51,7 @@ | |||
| <!-- Data --> | |||
| <dependency> | |||
| <groupId>org.mongodb</groupId> | |||
| <artifactId>mongo-java-driver</artifactId> | |||
| <artifactId>mongodb-driver-legacy</artifactId> | |||
There was a problem hiding this comment.
COMMENT: I'm glad to see there are still supporting older applications. :)
