OSTR-164 document ostrich exceptions #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwoodson
reviewed
Dec 8, 2016
| * [NoAvailableHostsException](../src/main/java/com/bazaarvoice/ostrich/exceptions/NoAvailableHostsException.java) an exception indicating that [host discovery](../src/main/java/com/bazaarvoice/ostrich/HostDiscovery.java) provided no end points. | ||
| * [NoCachedInstancesAvailableException](../src/main/java/com/bazaarvoice/ostrich/exceptions/NoCachedInstancesAvailableException.java) an exception to be thrown when a service cache does not have an idle cached instance for an end point, it does not have room to create a new one, and it is configured to fail when exhausted. | ||
| * [NoSuitableHostsException](../src/main/java/com/bazaarvoice/ostrich/exceptions/NoSuitableHostsException.java) an exception indicating that [load balancing algorithm](../src/main/java/com/bazaarvoice/ostrich/LoadBalanceAlgorithm.java) did not chose any end point from provided end points. | ||
| * [OnlyBadHostsException](../src/main/java/com/bazaarvoice/ostrich/exceptions/OnlyBadHostsException.java) an exception to be thrown when all available end points for service have been marked as bad (includes end points that have thrown exceptions during execution or end points that have a failed health check). |
There was a problem hiding this comment.
Good list and summaries. I wonder if a table with some additional pieces of data might be even more helpful:
| Exception | Service Discovered | Problem Domain | Description |
|---|---|---|---|
| NoSuitableHostsException | No | Ostrich | Indicates that load balancing algorithm did not chose any end point from provided end points. |
| OnlyBadHostsException | Yes | Service | Service endpoints discovered by Ostrich have all errored or are otherwise reporting unhealthy |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.