Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jackson 2.1.x #1

Merged
merged 1 commit into from
Feb 7, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Rison Parser and Generator for Jackson
======================================

A plugin for the [Jackson streaming JSON processor v1.9.x] (http://wiki.fasterxml.com/JacksonHome) that adds
A plugin for the [Jackson streaming JSON processor v2.1.x] (http://wiki.fasterxml.com/JacksonHome) that adds
support for reading and writing JSON objects in the [Rison] (http://mjtemplate.org/examples/rison.html)
serialization format.

Expand Down
12 changes: 6 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<groupId>com.bazaarvoice.jackson</groupId>
<artifactId>rison</artifactId>
<version>1.3-SNAPSHOT</version>
<version>2.0-SNAPSHOT</version>
<packaging>jar</packaging>

<name>Rison data format</name>
Expand All @@ -27,20 +27,20 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<jackson.version>1.9.9</jackson.version>
<jackson.version>2.1.2</jackson.version>
</properties>

<dependencies>
<dependency>
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-core-asl</artifactId>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>${jackson.version}</version>
</dependency>

<!-- Test dependencies -->
<dependency>
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-mapper-asl</artifactId>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${jackson.version}</version>
<scope>test</scope>
</dependency>
Expand Down
19 changes: 9 additions & 10 deletions src/main/java/com/bazaarvoice/jackson/rison/RisonFactory.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@

package com.bazaarvoice.jackson.rison;

import org.codehaus.jackson.JsonEncoding;
import org.codehaus.jackson.JsonFactory;
import org.codehaus.jackson.JsonParseException;
import org.codehaus.jackson.JsonParser;
import org.codehaus.jackson.ObjectCodec;
import org.codehaus.jackson.format.InputAccessor;
import org.codehaus.jackson.format.MatchStrength;
import org.codehaus.jackson.io.IOContext;
import com.fasterxml.jackson.core.JsonEncoding;
import com.fasterxml.jackson.core.JsonFactory;
import com.fasterxml.jackson.core.JsonParseException;
import com.fasterxml.jackson.core.ObjectCodec;
import com.fasterxml.jackson.core.format.InputAccessor;
import com.fasterxml.jackson.core.format.MatchStrength;
import com.fasterxml.jackson.core.io.IOContext;

import java.io.ByteArrayInputStream;
import java.io.IOException;
Expand Down Expand Up @@ -116,8 +115,8 @@ public final boolean isEnabled(RisonGenerator.Feature f) {
@Override
protected RisonParser _createJsonParser(Reader r, IOContext ctxt) throws IOException, JsonParseException {
return new RisonParser(ctxt, _parserFeatures, _risonParserFeatures, r, _objectCodec,
_rootCharSymbols.makeChild(isEnabled(JsonParser.Feature.CANONICALIZE_FIELD_NAMES),
isEnabled(JsonParser.Feature.INTERN_FIELD_NAMES)));
_rootCharSymbols.makeChild(isEnabled(JsonFactory.Feature.CANONICALIZE_FIELD_NAMES),
isEnabled(JsonFactory.Feature.INTERN_FIELD_NAMES)));
}

@Override
Expand Down
35 changes: 11 additions & 24 deletions src/main/java/com/bazaarvoice/jackson/rison/RisonGenerator.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,16 @@

package com.bazaarvoice.jackson.rison;

import org.codehaus.jackson.Base64Variant;
import org.codehaus.jackson.JsonGenerationException;
import org.codehaus.jackson.JsonGenerator;
import org.codehaus.jackson.JsonStreamContext;
import org.codehaus.jackson.ObjectCodec;
import org.codehaus.jackson.SerializableString;
import org.codehaus.jackson.impl.JsonGeneratorBase;
import org.codehaus.jackson.impl.JsonWriteContext;
import org.codehaus.jackson.io.IOContext;
import org.codehaus.jackson.io.NumberOutput;
import org.codehaus.jackson.io.SerializedString;
import com.fasterxml.jackson.core.Base64Variant;
import com.fasterxml.jackson.core.JsonGenerationException;
import com.fasterxml.jackson.core.JsonGenerator;
import com.fasterxml.jackson.core.JsonStreamContext;
import com.fasterxml.jackson.core.ObjectCodec;
import com.fasterxml.jackson.core.SerializableString;
import com.fasterxml.jackson.core.base.GeneratorBase;
import com.fasterxml.jackson.core.io.IOContext;
import com.fasterxml.jackson.core.io.NumberOutput;
import com.fasterxml.jackson.core.json.JsonWriteContext;

import java.io.IOException;
import java.io.Writer;
Expand All @@ -29,7 +28,7 @@
* which handles character encoding.
*/
public final class RisonGenerator
extends JsonGeneratorBase
extends GeneratorBase
{
/**
* Enumeration that defines all configurable features for Rison generators.
Expand Down Expand Up @@ -176,18 +175,6 @@ public final void writeFieldName(String name) throws IOException, JsonGeneratio
_writeFieldName(name, (status == JsonWriteContext.STATUS_OK_AFTER_COMMA));
}

@Override
public final void writeFieldName(SerializedString name)
throws IOException, JsonGenerationException
{
// Object is a value, need to verify it's allowed
int status = _writeContext.writeFieldName(name.getValue());
if (status == JsonWriteContext.STATUS_EXPECT_VALUE) {
_reportError("Can not write a field name, expecting a value");
}
_writeFieldName(name, (status == JsonWriteContext.STATUS_OK_AFTER_COMMA));
}

@Override
public final void writeFieldName(SerializableString name)
throws IOException, JsonGenerationException
Expand Down
29 changes: 17 additions & 12 deletions src/main/java/com/bazaarvoice/jackson/rison/RisonParser.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,28 @@

package com.bazaarvoice.jackson.rison;

import org.codehaus.jackson.Base64Variant;
import org.codehaus.jackson.JsonParseException;
import org.codehaus.jackson.JsonParser;
import org.codehaus.jackson.JsonToken;
import org.codehaus.jackson.ObjectCodec;
import org.codehaus.jackson.impl.JsonParserBase;
import org.codehaus.jackson.io.IOContext;
import org.codehaus.jackson.sym.CharsToNameCanonicalizer;
import org.codehaus.jackson.util.ByteArrayBuilder;
import org.codehaus.jackson.util.TextBuffer;
import com.fasterxml.jackson.core.Base64Variant;
import com.fasterxml.jackson.core.JsonParseException;
import com.fasterxml.jackson.core.JsonParser;
import com.fasterxml.jackson.core.JsonToken;
import com.fasterxml.jackson.core.ObjectCodec;
import com.fasterxml.jackson.core.base.ParserBase;
import com.fasterxml.jackson.core.io.IOContext;
import com.fasterxml.jackson.core.sym.CharsToNameCanonicalizer;
import com.fasterxml.jackson.core.util.ByteArrayBuilder;
import com.fasterxml.jackson.core.util.TextBuffer;

import java.io.IOException;
import java.io.Reader;
import java.io.Writer;

/**
* This is a concrete implementation of {@link org.codehaus.jackson.JsonParser}, which is
* This is a concrete implementation of {@link JsonParser}, which is
* based on a {@link java.io.Reader} to handle low-level character
* conversion tasks.
*/
public class RisonParser
extends JsonParserBase
extends ParserBase
{
/**
* Enumeration that defines all configurable features for Rison parsers.
Expand Down Expand Up @@ -386,6 +386,11 @@ public int getTextOffset() throws IOException, JsonParseException
return 0;
}

@Override
public Object getEmbeddedObject() throws IOException, JsonParseException {
return null;
}

@Override
public byte[] getBinaryValue(Base64Variant b64variant)
throws IOException, JsonParseException
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/bazaarvoice/jackson/rison/ARisonTest.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.bazaarvoice.jackson.rison;

import org.codehaus.jackson.JsonFactory;
import org.codehaus.jackson.map.ObjectMapper;
import com.fasterxml.jackson.core.JsonFactory;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.bazaarvoice.jackson.rison;

import org.codehaus.jackson.annotate.JsonProperty;
import org.codehaus.jackson.map.ObjectMapper;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.testng.annotations.Test;

import java.io.IOException;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.bazaarvoice.jackson.rison;

import org.codehaus.jackson.JsonParseException;
import org.codehaus.jackson.map.ObjectMapper;
import com.fasterxml.jackson.core.JsonParseException;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.testng.annotations.Test;

import java.io.IOException;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.bazaarvoice.jackson.rison;

import org.codehaus.jackson.map.ObjectMapper;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.testng.annotations.Test;

import java.io.IOException;
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/bazaarvoice/jackson/rison/MappingTest.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.bazaarvoice.jackson.rison;

import org.codehaus.jackson.annotate.JsonProperty;
import org.codehaus.jackson.map.ObjectMapper;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.testng.annotations.Test;

import java.io.IOException;
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/bazaarvoice/jackson/rison/ORisonTest.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.bazaarvoice.jackson.rison;

import org.codehaus.jackson.JsonFactory;
import org.codehaus.jackson.map.ObjectMapper;
import com.fasterxml.jackson.core.JsonFactory;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;

Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/bazaarvoice/jackson/rison/RisonTest.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.bazaarvoice.jackson.rison;

import org.codehaus.jackson.JsonFactory;
import org.codehaus.jackson.map.ObjectMapper;
import com.fasterxml.jackson.core.JsonFactory;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;

Expand Down