Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly calculate and incorporate Viewport information in Rekuho #67

Closed
elkowar opened this issue Dec 26, 2022 · 0 comments · Fixed by #92
Closed

Properly calculate and incorporate Viewport information in Rekuho #67

elkowar opened this issue Dec 26, 2022 · 0 comments · Fixed by #92
Assignees
Labels
topic-frontend Things that relate to the frontend in general

Comments

@elkowar
Copy link
Contributor

elkowar commented Dec 26, 2022

The communication with the backend implemented in #60 is very basic. We still need to implement viewport logic:

  • Line numbers need to be offset by the first_line value we get from core
  • viewport width and height need to be properly sent to the backend
  • We should set the required framework for scrolling to work
@elkowar elkowar added the topic-frontend Things that relate to the frontend in general label Dec 26, 2022
@elkowar elkowar added this to the First Prototype milestone Dec 26, 2022
@druskus20 druskus20 modified the milestone: First Prototype Dec 27, 2022
@elkowar elkowar linked a pull request Jan 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-frontend Things that relate to the frontend in general
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants