Communication between backend and frontend #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
druskus20
force-pushed
the
frontend-drusk
branch
2 times, most recently
from
89ac5cb
to
34ab3ad
Compare
druskus20
commented
Dec 26, 2022
| @@ -160,21 +190,44 @@ | |||
| <!-- TODO: Implement scrollbars --> | |||
| <!-- <Scrollbar /> --> | |||
| <!-- <Scrollbar /> --> | |||
There was a problem hiding this comment.
Is this resolved @gwimm?
druskus20
force-pushed
the
frontend-drusk
branch
from
e8c4cc3
to
34ab3ad
Compare
We also remove a lot of the previously implement local editor state logic, as this is now handled by the actual core server.
elkowar
force-pushed
the
frontend-drusk
branch
from
34ab3ad
to
4c316d2
Compare
We convert kanagawa.js to kanagawa.ts to make typescript not want to compile the file into itself, and add the @types/offscreencanvas dependency
elkowar
force-pushed
the
frontend-drusk
branch
from
4c316d2
to
0f2a2b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds communication between backend and frontend through WebSockets. It is also a major cleanup made by @elkowar.