-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rules_jvm_contrib
to the bazel-contrib
org
#27
Comments
I think this is the forcing function for us to address #3 A couple q's on this one in particular:
|
Answers!
|
And some comments about the relevant open questions in #3
The only reason this repo exists under my own username on GitHub is to facilitate this discussion and the inclusion of the repo in |
Ivo's talk at BazelCon gave me the impression that "starlarkification" is happening. I'd be curious to hear from someone on the Bazel team about whether we can land some of this functionality in rules_java. "quiescent" is a nice word for abandoned, and I'd hope we can push them to either archive the repo if they don't intend to move forward, or else give us a roadmap to indicate whether we can fix |
My impression is that the "starlarkification" for the java rules is still quite a long way out, and I'm not sure that |
Starlarkification is actually progressing quite nicely (see https://github.com/bazelbuild/bazel/tree/master/src/main/starlark/builtins_bzl/common/java for Java), just not in |
So does this mean that If the answer is that the process will take more than a month or two, I think it would be better to accept |
I don't know. @comius Could you explain what the short- to l mid-term plan for |
@comius, if you could also comment about whether the changes in this repository would be accepted into
|
Based on the lack of reply from @comius I'm guessing Google doesn't have a plan for rules_java. I wish they would just archive it for now, which can be reversed once there's a plan. @cushon are you still active in Bazel-Java? That aside, I'm supportive of adding your rules_jvm_contrib. Any other @bazel-contrib/rules-authors who can voice support? A bit of bikeshedding, does it make sense to have "contrib" appear twice in the "bazel-contrib/rules_jvm_contrib"? We could just have a |
Would a standard WORKSPACE naming convention of |
I can rename this anyway that people think is best, but my preference is to keep
I agree that it's a little ungainly to have "contrib" twice when looking at the GitHub URL, but the workspace name that people import into the projects will just be Having said all that, @jsharpe's suggestion has all these properties, but in a different order :) In short, I'll happily go along with any reasonable decision. |
My preference is GH Bazel style guide says that rulesets should have workspace name in reverse DNS
|
I'll rename the workspace. |
+1 - it's super useful to have a space to put this stuff, and if there's not an official space for it, this feels like the right approach.
SGTM. My instinct is to do the repetitive thing (repo name == workspace name is a quite nice pattern), but I care much less about the colour of the bikeshed than that it's built. |
+1 -- Google is intending to push out a rules_kotlin at some point so we'll end up moving the current one. |
Fully agreed. It will also make it easier to search for help. |
Lots of interesting topics here, some thoughts:
|
In response to the last point: these rules are the ones we're using at work for our Java development. They're widely used by teams, and we plan on continuing to support these rules as part of our regular development processes. My team and I are active participants of other rulesets, including TL;DR: we'll keep the lights on :) |
The ruleset has been renamed to |
https://github.com/bazel-contrib/rules_jvm is here now. |
Hey all, I'm back from vacations. True, rules_java seems abandoned and it contains at the moment hollow implementations (that call-back native implementation). The short term plan for rules_java is to resurrect it with Starlark implementation of Java rules that matches the native implementation together with unit and integration tests written in Starlark. Anything beyond this is not defined at the moment (branching, maintaining, converging, diverging). I'm open to contributions. rules_java will need to reach and sustain a very high code quality to make contributions possible though. I believe there are big monorepos that depend on native Java ruleset and even small changes come at a high price. |
At work, we've been using a suite of java rules and macros that make working on a larger java project smoother when using Bazel. Our ruleset includes:
glob
s of java rules that integrate with the above.As part of the process of Open Sourcing this, I've been given permission to host the repo here: https://github.com/shs96c/rules_jvm_contrib but I believe that this should live somewhere under
bazel-contrib
.The text was updated successfully, but these errors were encountered: