Prepare next release #131
Merged
Prepare next release #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is superfluous noise as we don't deploy the examples
The default value is 0. While the next release will be a breaking change, imho the compatibility_level is counted starting with the first bzlmod release, which is still pending. The compatibility_level is remove completely, as the bazel-central-registry maintainers don't want modules to explicitly mention the default value.
We should be aware of incompatibilities to upcoming Bazel versions as early as possible. We reorder the arguments as increasing version from left to right seems to be the dominant style in the bcr.
The tests in the examples directory ensure the bazelized mypy understands a lot of Python code examples. This is great, but is missing testing for expected failures. The test script in the root module does perform such tests. Ideally, there would be a directory with all relevant integration tests which uses the root module as external dependency. For now this largish refactoring is out of scope and thus we test both the root module itself and the examples.
- Advertise bzlmod as preferred option due to WORKSPACE being legacy - Do not explain how to use bzlmod. The information is not sufficient to understand properly what bzlmod is about for somebody new to bzlmod. The information is superfluous for everybody who has read the bzlmod doc. - Fix WORKSPACE template to work with current HEAD
chrisirhc
reviewed
Jun 21, 2024
| - "//..." | ||
| shell_commands: | ||
| - ./test.sh | ||
| test_examples: |
|
@adzenith |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the changes are opinionated. Most are independent from each other and can be dropped if demanded.
Full details are in the commit messages.