Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove_child_wksp_symlinks_test fails on windows #333

Open
peakschris opened this issue Jun 29, 2024 · 0 comments
Open

remove_child_wksp_symlinks_test fails on windows #333

peakschris opened this issue Jun 29, 2024 · 0 comments
Assignees
@peakschris

Comments

@peakschris
Copy link
Contributor

This test is failing:

bazel --windows_enable_symlinks //tests/tools_tests:remove_child_wksp_bazel_symlinks_test --enable_runfiles

move_child_wksp_bazel_symlinks_test/test.log
Executing tests from //tests/tools_tests:remove_child_wksp_bazel_symlinks_test
-----------------------------------------------------------------------------
Expected child_a symlink not to exist. /d/udu/b/azrngxdp/execroot/_main/bazel-out/x64_windows-fastbuild/bin/tests/tools_tests/remove_child_wksp_bazel_symlinks_test.exe.runfiles/_main/parent/examples/child_a/bazel-child_a
@peakschris peakschris mentioned this issue Jun 29, 2024
Merged
cgrindel pushed a commit that referenced this issue Jul 3, 2024
@peakschris
fix: windows functionality and tests (#334)
b40e501 
There are four issues when running on windows:

1.
#330
2.
#331
3.
#332
4.
#333

This PR fixes 3 and 4.

There are related PRs in bazel-skylib and bazel-starlib. There is no
dependency -- the PRs can close in any order.
- cgrindel/bazel-starlib#446 (fixes 1)
- bazelbuild/bazel-skylib#527 (fixes 2)

### Test results:
Before:
--enable_runfiles: 0 pass
--noenable_runfiles: 0 pass

After this PR:
--enable_runfiles: 52 pass, 19 failures
--noenable_runfiles: 51 pass, 20 failures (17 are doc diff-tests due to
bazel-starlib)

After this PR, together with wip PRs for 1 and 2:
--enable_runfiles: 71 pass, 0 failures
--noenable_runfiles: 51 pass, 20 failures (all due to bazel-starlib)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peakschris peakschris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peakschris