Test code more accurately detects dependencies #153

Before, some slices of strings contained both packages and strings, and we weren't clearly handling each correctly. Instead, be explicit about where we're using each.

Previously we were treating testonly libraries as unique packages in their own namespace. Instead, treat them as having the correct package name, but embed the "is testonly" data in a struct so we can choose to filter on it flexibly as we wish.

Previously, test targets assumed that they had matching production code they were testing, and would error if it couldn't be found. Instead, treat this as a normal occurrence, as often test code exists in its own package with no directly corresponding production code package.

This only works if there was no non-test package providing the same package. We don't automatically set the visibility for the depended-on code - this is an explicit decision that should be made by a human as to whether that dependency should be allowed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test code more accurately detects dependencies #153

Test code more accurately detects dependencies #153

Commits on Mar 2, 2023