Add a bzlmod module definition #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before we can land this PR, we need bazelbuild/rules_jvm_external#880 to have been landed and pushed to a release in the BCR. |
illicitonion
approved these changes
Mar 24, 2023
rdesgroppes
added a commit
to rdesgroppes/rules_jvm
that referenced
this pull request
Apr 26, 2023
On the one hand, bazel-contrib#115 didn't account for the presence of `maven` in `tools/update-dependencies.sh`. On the other hand, repinning dependencies happens to require `bzlmod` to be disabled, similarly to `stardoc` (as mentioned in bazel-contrib#170). The present change therefore addresses these issues and applies resulting updates.
rdesgroppes
added a commit
to rdesgroppes/rules_jvm
that referenced
this pull request
Apr 26, 2023
On the one hand, bazel-contrib#115 didn't account for the presence of `maven` in `tools/update-dependencies.sh`. On the other hand, it turns out that re-pinning dependencies requires that `bzlmod` be disabled, as was done for `stardoc` in bazel-contrib#170. The present change therefore addresses these issues and applies resulting updates.
illicitonion
pushed a commit
that referenced
this pull request
Apr 26, 2023
On the one hand, #115 didn't account for the presence of `maven` in `tools/update-dependencies.sh`. On the other hand, it turns out that re-pinning dependencies requires that `bzlmod` be disabled, as was done for `stardoc` in #170. The present change therefore addresses these issues and applies resulting updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.