Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting script #20

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Add formatting script #20

merged 1 commit into from
Apr 28, 2022

Conversation

stevebarrau
Copy link
Collaborator

In order to remove unrelated changes from #19, I would like to agree on a format (and tool to apply it) in this PR.

These changes add:

  • a formatting script that runs:
  • a dependencies update script to repin both:
    • frozen deps
    • local maven deps

I would like guidance on how to enforce this in CI.

Note: tried adding buildifier as well, but hit a variation of bazelbuild/stardoc#112 so I ended up not doing it.

Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@shs96c shs96c merged commit 2cb8467 into bazel-contrib:main Apr 28, 2022
@stevebarrau stevebarrau deleted the add-google-java-format branch April 29, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants