feat: implement structure_test #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
structure_test
branch
18 times, most recently
from
ea4e833
to
ede2d6c
Compare
thesayyn
force-pushed
the
structure_test
branch
5 times, most recently
from
c63bea7
to
b073841
Compare
thesayyn
force-pushed
the
structure_test
branch
from
b073841
to
12ef4d0
Compare
thesayyn
force-pushed
the
structure_test
branch
2 times, most recently
from
8d39609
to
4989f92
Compare
thesayyn
force-pushed
the
structure_test
branch
from
4989f92
to
d64c23c
Compare
thesayyn
force-pushed
the
structure_test
branch
5 times, most recently
from
dbb7d89
to
66c966d
Compare
f0rmiga
suggested changes
Nov 21, 2022
| # for why this is needed. | ||
| _LAUNCHER_TMPL = """ | ||
| export BAZEL_BINDIR=. | ||
| source {executable_path} |
There was a problem hiding this comment.
Why does it use source instead of exec?
There was a problem hiding this comment.
1- avoid $0 type of bugs. RUNFILES helper relies on that heavily.
2- any future implicit reliance of executable_path being the entrypoint.
There was a problem hiding this comment.
tried with exec. it doesn't work with it.
thesayyn
force-pushed
the
structure_test
branch
2 times, most recently
from
d4fa9d9
to
3658ad2
Compare
thesayyn
force-pushed
the
structure_test
branch
from
3658ad2
to
1ab00e6
Compare
thesayyn
force-pushed
the
structure_test
branch
from
7ceb53c
to
6b518cc
Compare
thesayyn
force-pushed
the
structure_test
branch
from
6b518cc
to
d1bbc21
Compare
f0rmiga
approved these changes
Dec 5, 2022
|
@thesayyn WDYT about naming it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.