fix: add tars into action inputs #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
approved these changes
May 30, 2024
|
I guess we don't have a way to add the missing test that would have been red? Should we add RBE to rules_oci nowish? |
If we have some free tier RBE access yes that would give us more coverage. It would prevent a lot of accidental features/bugs like these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.0, we promised that
tarswere no longer directly inputs to oci_image, but it was never possible to do it because of subtle ways of how bazel works. Even though it worked with most execution strategies, it did not work with RBE and BwoB because of how bazel calculates hashes for treeartifacts.Discussion here: bazelbuild/bazel#22504