Stop specifiying a manual group for xcodeproj sources #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcodegen can now intuit groups properly for paths that start with .., and are above the current directly on disk
gyfelton
reviewed
Sep 26, 2020
| @@ -326,15 +326,13 @@ def _gather_asset_sources(target_info, path_prefix): | |||
|
|
|||
| for s in target_info.asset_srcs.to_list(): | |||
| short_path = s.short_path | |||
| group = paths.dirname(short_path) | |||
There was a problem hiding this comment.
that's awesome! might help fix .lprog issue as well
gyfelton
approved these changes
Sep 26, 2020
justinseanmartin
approved these changes
Sep 28, 2020
amberdixon
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcodegen can now intuit groups properly for paths that start with .., and are above the current directly on disk
(thanks to yonaskolb/XcodeGen#892).
Pointing to my fork for now, since there hasn't been a recent release