Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain setup instructions #290

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

keith
Copy link
Member

@keith keith commented Dec 19, 2023

The big change here is that bazel 7.x shipped with toolchain resolution
flipped, so that no longer requires any configuration.

The big change here is that bazel 7.x shipped with toolchain resolution
flipped, so that no longer requires any configuration.
@brentleyjones
Copy link
Collaborator

So we don't need this anymore for Bazel 7? What changed there?

build--apple_crosstool_top=@local_config_apple_cc//:toolchain
build--crosstool_top=@local_config_apple_cc//:toolchain
build--host_crosstool_top=@local_config_apple_cc//:toolchain

@keith
Copy link
Member Author

keith commented Dec 19, 2023

default flag flip for toolchain resolution

@brentleyjones
Copy link
Collaborator

Should we mention that people need to set those still if they flip the flag off?

@keith
Copy link
Member Author

keith commented Dec 19, 2023

i left it out to try and reduce the instruction count making the assumption that those people are "on their own", especially since on rolling that flag is already a no-op, but I can add it if you think we should

@keith keith merged commit d87e8b0 into master Dec 19, 2023
9 checks passed
@keith keith deleted the ks/update-toolchain-setup-instructions branch December 19, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants