Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display non-zero exit status in summary #39

Closed
meisterT opened this issue Jun 19, 2019 · 1 comment · Fixed by #48
Closed

Display non-zero exit status in summary #39

meisterT opened this issue Jun 19, 2019 · 1 comment · Fixed by #48
Labels
enhancement New feature or request P2

Comments

@meisterT
Copy link
Member

Description of the problem / feature request:

It's easy to miss a non-zero exit status in the long build log. It should also be visible in the results summary in the end.

If not all runs have the same status, you may even consider excluding measurements from non-zero exit code runs.

Feature requests: what underlying problem are you trying to solve with this feature?

Make it easy to detect errors / flakiness.

@joeleba
Copy link
Member

joeleba commented Jun 19, 2019

This is related to #31. To allow both approaches (stopping the script immediately vs just reporting failures), we can introduce a flag --carry_on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants