Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _single_run to perform the prefetch run #3

Merged
merged 1 commit into from Mar 18, 2019
Merged

Conversation

joeleba
Copy link
Member

@joeleba joeleba commented Mar 18, 2019

We've been (sort of) breaking abstraction by performing bazel.command directly in the _run_benchmark method. This change would improve the overall code readability.

Changes:

  • Use _single_run to perform the prefetch run
  • Change the signature of _single_run to accept args instead of separating expressions and options.
  • Minor: Change "build env" to "build event" in a log entry.

@joeleba joeleba requested a review from meisterT March 18, 2019 13:00
@joeleba joeleba merged commit e52d8c0 into master Mar 18, 2019
@joeleba joeleba deleted the refactoring branch March 18, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants