Add rules_haskell module version 0.17 #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdv
force-pushed
the
rules_haskell-0.17
branch
2 times, most recently
from
8538827
to
cb15708
Compare
avdv
changed the title
avdv
force-pushed
the
rules_haskell-0.17
branch
from
cb15708
to
716b2da
Compare
avdv
force-pushed
the
rules_haskell-0.17
branch
from
716b2da
to
b1e0984
Compare
alexeagle
added
the
presubmit-auto-run
|
CI says
I'll add a tag here to bypass that check, but it's worth asking if you could easily include a release artifact in GH release. |
alexeagle
added
the
skip-url-stability-check
Thank you, I'll see that we change our release pipeline to create an artifact for releases. |
avdv
force-pushed
the
rules_haskell-0.17
branch
7 times, most recently
from
0e274d1
to
0f73014
Compare
|
Currently, this fails on Windows (https://buildkite.com/bazel/bcr-presubmit/builds/2394#018b8ef4-da85-4da0-ba4b-aa4dcd90c618): It already worked once before (https://buildkite.com/bazel/bcr-presubmit/builds/2382#018b8a78-c378-4a67-8fb4-9c3d69d998de) -- for the same commit 0f73014 😕 What gives? Why do I get different results for the same commit? |
avdv
force-pushed
the
rules_haskell-0.17
branch
2 times, most recently
from
f6cfce0
to
1ca24a1
Compare
The stack tool could not download the root.json file from hackage. It failed with a TLS exception caused by a missing CA for the server certificate. It seems that opening a web page with Internet Explorer or with powershell causes the certificates to be updated. See commercialhaskell/stack#234
Register the cc toolchain that comes with the GHC bindist.
Our test module depends on rules_nixpkgs' modules which are not available yet.
It is currently failing with: ``` this rule is missing dependency declarations for the following files included by 'gzwrite.c': 'C:/b/f3c3gu33/execroot/_main/external/rules_haskell~0.17~haskell_toolchains~rules_haskell_ghc_windows_amd64/mingw/x86_64-w64-mingw32/include/stdio.h' 'C:/b/f3c3gu33/execroot/_main/external/rules_haskell~0.17~haskell_toolchains~rules_haskell_ghc_windows_amd64/mingw/x86_64-w64-mingw32/include/corecrt_stdio_config.h' 'C:/b/f3c3gu33/execroot/_main/external/rules_haskell~0.17~haskell_toolchains~rules_haskell_ghc_windows_amd64/mingw/x86_64-w64-mingw32/include/corecrt.h' ... ```
avdv
force-pushed
the
rules_haskell-0.17
branch
from
1ca24a1
to
b9329b1
Compare
|
I could not resolve the problem on Windows, so I have disabled that platform for now. CI is now 🟢 Could anyone have a look please? |
fmeum
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the newly released rules_haskell version 0.17 to the BCR. See https://github.com/tweag/rules_haskell/releases/tag/v0.17