-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add module rules_tf #1265
add module rules_tf #1265
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
8f8a650
to
bef403e
Compare
hi @fmeum do you know why i'm hitting this issue : https://buildkite.com/bazel/bcr-presubmit/builds/2936#018cd966-3ede-4bcc-8826-d4cac252a986 thanks a lot |
Hmm, I don't. Cc @meteorcloudy |
This is because the MODULE.bazel file in the tar file has no write permission:
Fixing the CI script at bazelbuild/continuous-integration#1844 |
1f614c2
to
3703cf9
Compare
thanks a lot for having fixed this. i'm sorry but it seems i'm hitting another issue:
is this something i should include in my package ? thanks a lot |
It looks like the test module directory |
oh correct. i didn't think i had to include it in the archive will fix thanks a lot |
807de15
to
2de4ec2
Compare
2de4ec2
to
8575fc8
Compare
hi @fmeum i finally managed to make it green. is there anything i should do? thanks a lot. best regards |
this PR add module https://github.com/yanndegat/rules_tf to the BCR