Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add module rules_tf #1265

Merged
merged 2 commits into from
Jan 9, 2024
Merged

add module rules_tf #1265

merged 2 commits into from
Jan 9, 2024

Conversation

yanndegat
Copy link
Contributor

this PR add module https://github.com/yanndegat/rules_tf to the BCR

Copy link

google-cla bot commented Jan 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jan 5, 2024
@yanndegat yanndegat force-pushed the add_rules_tf branch 2 times, most recently from 8f8a650 to bef403e Compare January 5, 2024 11:33
@yanndegat
Copy link
Contributor Author

hi @fmeum

do you know why i'm hitting this issue : https://buildkite.com/bazel/bcr-presubmit/builds/2936#018cd966-3ede-4bcc-8826-d4cac252a986

thanks a lot

@fmeum
Copy link
Contributor

fmeum commented Jan 5, 2024

Hmm, I don't. Cc @meteorcloudy

@meteorcloudy
Copy link
Member

meteorcloudy commented Jan 5, 2024

This is because the MODULE.bazel file in the tar file has no write permission:

$ ll
total 48
drwxr-xr-x   8 pcloudy  primarygroup    256 Jan  5 15:15 ./
drwxr-xr-x  14 pcloudy  primarygroup    448 Jan  5 15:15 ../
-r--r--r--   1 pcloudy  primarygroup    686 Jan  1  2000 BUILD.bazel
-r--r--r--   1 pcloudy  primarygroup  11358 Jan  1  2000 LICENSE
-r--r--r--   1 pcloudy  primarygroup   1840 Jan  1  2000 MODULE.bazel
-r--r--r--   1 pcloudy  primarygroup      0 Jan  1  2000 WORKSPACE
drwxr-xr-x  10 pcloudy  primarygroup    320 Jan  1  2000 tf/
-r--r--r--   1 pcloudy  primarygroup    652 Jan  1  2000 version.bzl

Fixing the CI script at bazelbuild/continuous-integration#1844

@yanndegat
Copy link
Contributor Author

This is because the MODULE.bazel file in the tar file has no write permission:

$ ll
total 48
drwxr-xr-x   8 pcloudy  primarygroup    256 Jan  5 15:15 ./
drwxr-xr-x  14 pcloudy  primarygroup    448 Jan  5 15:15 ../
-r--r--r--   1 pcloudy  primarygroup    686 Jan  1  2000 BUILD.bazel
-r--r--r--   1 pcloudy  primarygroup  11358 Jan  1  2000 LICENSE
-r--r--r--   1 pcloudy  primarygroup   1840 Jan  1  2000 MODULE.bazel
-r--r--r--   1 pcloudy  primarygroup      0 Jan  1  2000 WORKSPACE
drwxr-xr-x  10 pcloudy  primarygroup    320 Jan  1  2000 tf/
-r--r--r--   1 pcloudy  primarygroup    652 Jan  1  2000 version.bzl

Fixing the CI script at bazelbuild/continuous-integration#1844

hi @meteorcloudy

thanks a lot for having fixed this.

i'm sorry but it seems i'm hitting another issue:

FileNotFoundError: [Errno 2] No such file or directory: '/var/lib/buildkite-agent/builds/bk-docker-j2dn/bazel-org-repo-root/output/tests/bcr/.bazelrc'

is this something i should include in my package ?

thanks a lot

@meteorcloudy
Copy link
Member

It looks like the test module directory tests/bcr doesn't exist in the source archive.

@yanndegat
Copy link
Contributor Author

It looks like the test module directory tests/bcr doesn't exist in the source archive.

oh correct. i didn't think i had to include it in the archive

will fix

thanks a lot

@yanndegat yanndegat force-pushed the add_rules_tf branch 2 times, most recently from 807de15 to 2de4ec2 Compare January 9, 2024 14:41
@yanndegat
Copy link
Contributor Author

hi @fmeum

i finally managed to make it green. is there anything i should do?

thanks a lot.

best regards

@Wyverald Wyverald merged commit 5fdfd0b into bazelbuild:main Jan 9, 2024
12 checks passed
antonovvk pushed a commit to antonovvk/bazel-central-registry that referenced this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants