Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolchain_utils@1.0.0-alpha.16 #1270

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

mattyclarkson
Copy link
Contributor

@mattyclarkson mattyclarkson commented Jan 5, 2024

A ruleset to simplify the creation of Bazel toolchains, eliminating as much boilerplate as possible.

For a real-world example of usage, see rules_coreutils

See the project README for more information.

This requires #1284 as the source tarball comes from a non-GitHub endpoint and does not use a sha256 integrity.

@mattyclarkson
Copy link
Contributor Author

First PR here, so bear with me whilst I get most things correct in presubmit.yml and sort out the validation checks.

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jan 5, 2024
@mattyclarkson
Copy link
Contributor Author

I'm hitting a self-signed certificate error on Windows.

* Download and unpack https://gitlab.arm.com/bazel/rules_toolchain/-/releases/v1.0.0-alpha.13/downloads/src.tar.gz
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain

I'm not aware that we are using a self-signed certificate.

image

The source archive download is working on other platforms, so a little confused why this is failing on Windows.

I will attempt to debug inside Windows Sandbox.

@mattyclarkson
Copy link
Contributor Author

Reproduced the certificate failure inside Windows Sandbox, which does not have the Arm self-signed certificates installed.

from urllib.request import urlopen
with urlopen("https://gitlab.arm.com/bazel/rules_toolchain/-/releases/v1.0.0-alpha.13/downloads/src.tar.gz") as stream:
    stream.read()

I'll pick up with our team to figure out how to remove that restriction on our certificate.

This only happens within Python. Using Powershell to retrieve the source tarball is fine so it will require more understanding to unlock the Windows CI run on ourside.

Until then, I'll comment out the Windows CI job.

@mattyclarkson mattyclarkson force-pushed the rules_toolchain branch 2 times, most recently from 6465026 to 7331ae1 Compare January 10, 2024 11:52
@mattyclarkson mattyclarkson changed the title Add rules_toolchain@1.0.0-alpha.13 Add rules_toolchain@1.0.0-alpha.15 Jan 10, 2024
@mattyclarkson mattyclarkson changed the title Add rules_toolchain@1.0.0-alpha.15 Add rules_toolchain@1.0.0-alpha.16 Jan 10, 2024
@mattyclarkson mattyclarkson marked this pull request as ready for review January 10, 2024 14:25
@mattyclarkson
Copy link
Contributor Author

RFC: @fmeum / @meteorcloudy

@meteorcloudy
Copy link
Member

I have no extra input for the Windows failure. Overall looks good if we can resolve the naming issue ;)

@mattyclarkson mattyclarkson changed the title Add rules_toolchain@1.0.0-alpha.16 Add toolchain_utils@1.0.0-alpha.16 Jan 19, 2024
@Wyverald Wyverald enabled auto-merge (squash) January 22, 2024 19:01
@Wyverald Wyverald merged commit 5ebf57f into bazelbuild:main Jan 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants