Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cel-spec@0.14.0 #1641

Merged
merged 1 commit into from Mar 25, 2024
Merged

cel-spec@0.14.0 #1641

merged 1 commit into from Mar 25, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Mar 17, 2024 •
edited

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (cel-spec) have been updated in this PR. Please review the changes.

@mmorel-35 mmorel-35 marked this pull request as ready for review March 17, 2024 21:02
@mmorel-35 mmorel-35 marked this pull request as draft March 17, 2024 21:03
@mmorel-35 mmorel-35 force-pushed the cel-spec/v0.14.0 branch 2 times, most recently from 7520a24 to 7416919 Compare March 17, 2024 21:32
@mmorel-35 mmorel-35 marked this pull request as ready for review March 17, 2024 21:32
@meteorcloudy meteorcloudy added the skip-url-stability-check Skip the URL stability check for the PR label Mar 18, 2024
@mmorel-35 mmorel-35 force-pushed the cel-spec/v0.14.0 branch 3 times, most recently from b0c1e0f to 135b4bb Compare March 22, 2024 15:19
@mmorel-35
Copy link
Contributor Author

@meteorcloudy , WDYT ?

@mmorel-35 mmorel-35 force-pushed the cel-spec/v0.14.0 branch 3 times, most recently from 6382cd7 to ec0c4d8 Compare March 22, 2024 19:10
@mmorel-35 mmorel-35 requested a review from Wyverald March 22, 2024 19:14
@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Mar 22, 2024
@mmorel-35 mmorel-35 force-pushed the cel-spec/v0.14.0 branch 2 times, most recently from 2697215 to 2290520 Compare March 22, 2024 20:43
meteorcloudy
meteorcloudy approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I strongly recommend to upstream the patches if possible so that we don't need them for future versions.

@meteorcloudy meteorcloudy merged commit 6e4b6d8 into bazelbuild:main Mar 25, 2024
18 checks passed
@mmorel-35 mmorel-35 deleted the cel-spec/v0.14.0 branch March 25, 2024 10:52
@mmorel-35 mmorel-35 mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@Wyverald Wyverald Awaiting requested review from Wyverald

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmorel-35 @bazel-io @Wyverald @meteorcloudy