Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riegeli@0.0.0-20231123-411cda7 #1834

Merged
merged 1 commit into from
Apr 17, 2024
Merged

riegeli@0.0.0-20231123-411cda7 #1834

merged 1 commit into from
Apr 17, 2024

Conversation

mmorel-35
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (riegeli) have been updated in this PR. Please review the changes.

@mmorel-35 mmorel-35 force-pushed the riegeli@0.0.0-20231123-411cda7 branch 2 times, most recently from 934c3b4 to c4de18f Compare April 16, 2024 18:42
@mmorel-35 mmorel-35 marked this pull request as draft April 17, 2024 05:28
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Apr 17, 2024 •
edited

Hi @QrczakMK,

I provide here a module version of riegeli aligned with the one actually used by fuzztest. It’s partially complete enough for fuzztest to work.

As you are the maintainer of riegeli, would you like to be designated as maintainer here so anyone providing a new version after this one will request your review ?

@mmorel-35 mmorel-35 force-pushed the riegeli@0.0.0-20231123-411cda7 branch from c8797ff to f47e522 Compare April 17, 2024 05:46
@mmorel-35 mmorel-35 marked this pull request as ready for review April 17, 2024 05:47
@mmorel-35 mmorel-35 force-pushed the riegeli@0.0.0-20231123-411cda7 branch from f47e522 to ed6f87b Compare April 17, 2024 08:04
@meteorcloudy
Copy link
Member

Can you send a PR to also upstream the Bzlmod patches?

@meteorcloudy meteorcloudy added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Apr 17, 2024
@mmorel-35 mmorel-35 force-pushed the riegeli@0.0.0-20231123-411cda7 branch 2 times, most recently from c1e84b7 to 7e340c9 Compare April 17, 2024 12:20
@mmorel-35 mmorel-35 force-pushed the riegeli@0.0.0-20231123-411cda7 branch from 7e340c9 to 1388da7 Compare April 17, 2024 12:27
@meteorcloudy
Copy link
Member

Any reason we are using an old commit from 2023 instead of the latest one?

@mmorel-35
Copy link
Contributor Author

Yes !
This is the version used by fuzztest on the main branch : https://github.com/google/fuzztest/blob/main/WORKSPACE#L60-L65

@meteorcloudy meteorcloudy merged commit 1c2bd9f into bazelbuild:main Apr 17, 2024
12 checks passed
@mmorel-35 mmorel-35 deleted the riegeli@0.0.0-20231123-411cda7 branch April 17, 2024 13:00
aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
@mmorel-35 @aiuto
riegeli@0.0.0-20231123-411cda7 (bazelbuild#1834)
8da480a 
Release:
https://github.com/google/riegeli/archive/411cda7f6aa81f8b8591b04cf141b1decdcc928c.tar.gz

Used by:
* https://github.com/google/fuzztest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmorel-35 @bazel-io @meteorcloudy