Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add magic_enum #1903

Closed
wants to merge 2 commits into from
Closed

add magic_enum #1903

wants to merge 2 commits into from

Conversation

zaucy
Copy link
Contributor

@zaucy zaucy commented Apr 29, 2024

No description provided.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (magic_enum) have been updated in this PR. Please review the changes.

This was referenced Apr 29, 2024
Closed
Open
@zaucy
Copy link
Contributor Author

zaucy commented Apr 29, 2024 •
edited

I'm a little confused by the CI error. Patch seemed to fail on some Windows CI (but not others) and then there's an error on some of the Debian CI that doesn't give a lot of information

@lalten
Copy link
Contributor

lalten commented May 10, 2024

bump on this :) No clue about the Windows error, but for the Linux one you could try to (temporarily) patch in a higher --experimental_ui_max_stdouterr_bytes in the .bazelrc?

stderr (/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/564d2f181201e0c9b383e74c8e273ef9/execroot/_main/bazel-out/_tmp/actions/stderr-10) 2099313 exceeds maximum size of --experimental_ui_max_stdouterr_bytes=1048576 bytes

@dieortin
Copy link
Contributor

Why is patching the .bazelrc needed? I thought only the one in the project root would apply, and not the ones in modules you depend on

@zaucy
Copy link
Contributor Author

zaucy commented May 31, 2024

the presubmit seems to read it for example here: https://buildkite.com/bazel/bcr-presubmit/builds/5043#018f2bef-01c2-40ac-a4c6-8c9ff1401613/128-136

@meteorcloudy
Copy link
Member

Looks like your .bazelrc file has CRLF line ending? Which doesn't match the patch file.

$ file .bazelrc
.bazelrc: ASCII text, with CRLF line terminators

Coverting to LF line ending could help with the windows failure.

@zaucy zaucy mentioned this pull request Jun 3, 2024
Merged
@zaucy
Copy link
Contributor Author

zaucy commented Jun 3, 2024 •
edited

Looks like your .bazelrc file has CRLF line ending?

Yeah it was a mistake. I've made a PR to clean that up. Neargye/magic_enum#358

Coverting to LF line ending could help with the windows failure.

For the patch file? In one of my previous commits in this PR I had the patch file using LF line endings and it failed https://buildkite.com/bazel/bcr-presubmit/builds/5038#018f2be4-1c33-4b6a-a0c9-3a29c6b62de1/147-180

I think what I'm going to do is just disable bazel 7.x so that patching the flag doesn't matter and then in the next magic_enum release 7.x can be added again.

@bazel-io
Copy link
Member

bazel-io commented Jun 3, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (magic_enum) have been updated in this PR. Please review the changes.

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jun 7, 2024
@bazel-io
Copy link
Member

Hello @mattyclarkson, modules you maintain (ape, rules_bzip2, rules_coreutils, rules_curl, rules_diff, rules_gzip, rules_squashfs, rules_zstd, toolchain_utils) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @alexeagle, modules you maintain (aspect_bazel_lib, aspect_rules_aws, aspect_rules_js, aspect_rules_lint, rules_buf, rules_oci, rules_proto, toolchains_protoc) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @kormide, modules you maintain (aspect_bazel_lib) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @CaerusKaru, modules you maintain (aspect_rules_aws) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @aspect-build, modules you maintain (aspect_rules_esbuild, aspect_rules_py, aspect_rules_rollup, aspect_rules_swc, aspect_rules_terser, rules_nodejs) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @gregmagolan, modules you maintain (aspect_rules_jasmine, aspect_rules_jest, aspect_rules_js, aspect_rules_ts, aspect_rules_webpack) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @jbedard, modules you maintain (aspect_rules_jasmine, aspect_rules_js, aspect_rules_ts) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @thesayyn, modules you maintain (aspect_rules_ts, rules_distroless, rules_oci, rules_proto) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @dzbarsky, modules you maintain (aws-in-a-box, libarchive, rules_itest) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @fmeum, modules you maintain (bazel_env.bzl, bazel_features, buildozer, gazelle, rules_fuzzing, rules_go, rules_jni) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @Wyverald, @meteorcloudy, modules you maintain (bazel_features) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @comius, modules you maintain (bazel_skylib, bazel_skylib_gazelle_plugin) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @Zetten, @adincebic, modules you maintain (bazel_sonarqube) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @sergeykhliustin, modules you maintain (bazelpods) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @agl, @bob-beck, @davidben, modules you maintain (boringssl) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @curoky, modules you maintain (catch2) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @lalten, modules you maintain (rules_appimage) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @yuyawk, modules you maintain (rules_build_error) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @nya3jp, modules you maintain (rules_contest) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @seh, modules you maintain (rules_cue) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @matts1, modules you maintain (rules_directory) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @loosebazooka, modules you maintain (rules_distroless) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @abrisco, modules you maintain (rules_helm) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @luispadron, modules you maintain (rules_ios) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @hvadehra, modules you maintain (rules_java) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @oxidase, modules you maintain (rules_poetry) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @rickeylev, @f0rmiga, modules you maintain (rules_python, rules_python_gazelle_plugin) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @p0deje, modules you maintain (rules_ruby) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @UebelAndre, @scentini, modules you maintain (rules_rust) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @cgrindel, modules you maintain (rules_swift_package_manager) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @ihavespoons, modules you maintain (rules_syft) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @mark-thm, @theoremlp, modules you maintain (rules_uv) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @brentleyjones, @BalestraPatrick, modules you maintain (rules_xcodeproj) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @Megakuul, modules you maintain (simplehttp) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @jpsim, modules you maintain (sourcekitten) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @keith, modules you maintain (sourcekitten, swift-syntax) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @zadlg, modules you maintain (tree-sitter-bazel) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @udaya2899, modules you maintain (versor) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (abseil-py, bazel_ci_rules, cctz, cel-spec, ceres-solver, civetweb, cli11, cpp-httplib, fp16, fxdiv, grpc-httpjson-transcoding, grpc, highs, jwt_verify_lib, libprotobuf-mutator, libzmq, magic_enum, opencensus-proto, proto-converter, protoc-gen-validate, pthreadpool, rules_pkl, ruy, scip, su-exec, tomlplusplus, xds) have been updated in this PR. Please review the changes.

@zaucy
Copy link
Contributor Author

zaucy commented Jun 14, 2024 •
edited

Very sorry everyone who just got pinged. I accidentally rebased against my fork and merged in a bunch of unrelated commits 😓

edit: I'm going to close the PR and open a new one so everyone doesn't have to manually unsubscribe. Sorry again for the noise!

@zaucy zaucy closed this Jun 14, 2024
@zaucy zaucy deleted the add-magic-enum branch June 14, 2024 20:58
@zaucy zaucy mentioned this pull request Jun 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zaucy @bazel-io @lalten @dieortin @meteorcloudy