Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules_swift@2.0.0-rc1 #2308

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @keith, @BalestraPatrick, @brentleyjones, @thii, modules you maintain (rules_swift) have been updated in this PR. Please review the changes.

brentleyjones
brentleyjones previously approved these changes Jun 25, 2024
bazel-io
bazel-io previously approved these changes Jun 25, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@meteorcloudy
Copy link
Member

ERROR: swift_argument_parser@1.3.0 depends on rules_swift@1.16.0 with compatibility level 1, but <root> depends on rules_swift@2.0.0-rc1 with compatibility level 2 which is different

Is this helpful? Does swift_argument_parser@1.3.0 actually work with rules_swift@2.0.0-rc1?

@brentleyjones
Copy link
Contributor

I had to bump that dep, and now I'll bump this one.

@bazel-io bazel-io dismissed stale reviews from brentleyjones and themself June 25, 2024 14:13

Require module maintainers' approval for newly pushed changes.

BalestraPatrick and others added 2 commits June 25, 2024 09:15
Signed-off-by: Brentley Jones <github@brentleyjones.com>
@brentleyjones brentleyjones force-pushed the bazelbuild/rules_swift@2.0.0-rc1-e51bfd4d branch from 226ce4f to 99d0867 Compare June 25, 2024 14:15
Signed-off-by: Brentley Jones <github@brentleyjones.com>
@brentleyjones brentleyjones added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jun 25, 2024
Signed-off-by: Brentley Jones <github@brentleyjones.com>
@brentleyjones brentleyjones merged commit 5a283c6 into bazelbuild:main Jun 25, 2024
12 checks passed
@brentleyjones brentleyjones deleted the bazelbuild/rules_swift@2.0.0-rc1-e51bfd4d branch June 25, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants