Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libconfig@1.7.3 (#2455) #2456

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (libconfig) have been updated in this PR. Please review the changes.

@meteorcloudy
Copy link
Member

Please check the presubmit

@dmitry-j-mikhin
Copy link
Contributor Author

Thanks, will try to fix

@dmitry-j-mikhin
Copy link
Contributor Author

@meteorcloudy I added an experimental fix, can't test it now because I don't have access to the Windows VM. But it looks like the additional defines should fix compilation errors on Windows.

@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jul 19, 2024
@dmitry-j-mikhin dmitry-j-mikhin changed the title libconfig@1.7.3 (#2445) libconfig@1.7.3 (#2455) Jul 20, 2024
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy merged commit 9fecdfc into bazelbuild:main Jul 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants