Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc v1.48.1.bcr.1 #734

Merged
merged 1 commit into from Jul 7, 2023
Merged

Add grpc v1.48.1.bcr.1 #734

merged 1 commit into from Jul 7, 2023

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Jul 2, 2023

Bumps the versions of zlib and rules_go past all yanked versions.

@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Jul 2, 2023
@fmeum fmeum requested a review from Wyverald July 2, 2023 09:28
@fmeum fmeum enabled auto-merge (squash) July 2, 2023 09:48
@meisterT
Copy link
Member

meisterT commented Jul 3, 2023

After this has been merged (likely after the US holidays) and Bazel has been updated we need to revert bazelbuild/bazel#18828

@alexeagle
Copy link
Contributor

Drive-by comment - does the grpc repo actually contain Go code? It seems like we've done something wrong with grpc needs to depend on ~all languages that end-users might want a grpc runtime for...

@fmeum
Copy link
Contributor Author

fmeum commented Jul 7, 2023

CI proves that rules_go is a required dep. I fully agree that this shouldn't be the case and grpc should potentially be split up into a generic and per-language modules, but I doubt anyone will find the time to do that anytime soon...

Bumps the versions of `zlib` and `rules_go` passed all yanked versions.
@fmeum fmeum enabled auto-merge (squash) July 7, 2023 07:48
@fmeum fmeum disabled auto-merge July 7, 2023 07:48
@fmeum fmeum enabled auto-merge (squash) July 7, 2023 07:48
@fmeum fmeum merged commit 28590c7 into bazelbuild:main Jul 7, 2023
7 checks passed
@fmeum fmeum deleted the grpc-1.48.1.bcr.1 branch July 7, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants