Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Bazel for Python tools #86

Closed
wants to merge 3 commits into from

Conversation

hobofan
Copy link
Contributor

@hobofan hobofan commented May 17, 2022

A quick setup of a Bazel workspace for the repo to make it easy to run the tools.

Sets up a hermetic Python toolchain with the latest version of rules_python.
As there were multiple breaking (and significant) changes between the current version (0.8.1) and the latest version published to the registry (0.4.0), I've opted for setting it up an old-fashioned workspace for now. Once there is a current rules_python release, I would adjust the PR to utilize bzlmod.


RELATED #46

README.md Outdated Show resolved Hide resolved
@hobofan hobofan force-pushed the setup_workspace branch 3 times, most recently from 169ccab to 3f00dd1 Compare May 23, 2022 18:41
alexeagle
alexeagle previously approved these changes May 23, 2022
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

.github/workflows/verify_source_urls.yml Outdated Show resolved Hide resolved
.github/workflows/verify_source_urls.yml Outdated Show resolved Hide resolved
tools/add_module.py Show resolved Hide resolved
hobofan and others added 2 commits August 3, 2022 08:52
GH actions always includes bazelisk on their base images
@alexeagle alexeagle force-pushed the setup_workspace branch 4 times, most recently from 2afe6a8 to bc4028f Compare August 3, 2022 16:13
@alexeagle
Copy link
Contributor

@hobofan I made some updates here now that rules_python 0.10.2 is in the registry - but I'm still struggling to delete the content from /WORKSPACE which should no longer be needed. Run out of time for now so let's see who finds time to come back to this first :)

@hobofan
Copy link
Contributor Author

hobofan commented Aug 18, 2023

Closing. Has been superseded by #416

@hobofan hobofan closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants