Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add googletest@1.14.0.bcr.1 #970

Merged
merged 1 commit into from Oct 4, 2023
Merged

Add googletest@1.14.0.bcr.1 #970

merged 1 commit into from Oct 4, 2023

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Oct 3, 2023

Adds a missing dep on re2.

Fixes #969

@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Oct 3, 2023
@fmeum
Add googletest@1.14.0.bcr.1
981a0d6 
Adds a missing dep on `re2`.
@fmeum fmeum marked this pull request as ready for review October 3, 2023 07:04
bgianfo
bgianfo approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@bgianfo bgianfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@fmeum fmeum merged commit c9390dd into bazelbuild:main Oct 4, 2023
8 checks passed
@fmeum fmeum deleted the googletest branch October 4, 2023 09:16
@luangong luangong mentioned this pull request Jan 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgianfo bgianfo bgianfo approved these changes

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: googletest with absl mode doesn't actually work
3 participants
@fmeum @bgianfo @meteorcloudy