Check minimum rules_go version #51
Labels
Comments
jayconrod
pushed a commit
to jayconrod/bazel-gazelle
that referenced
this issue
Jan 4, 2018
* Added a small internal/version package for parsing and comparing versions. * Added repo.FindExternalRepo, which locates the directory of an external repository. This will be used for indexing later. * Added checkRulesGoVersion which parses RULES_GO_VERSION out of def.bzl and compares it to a minimum. Fixes bazelbuild#51
jayconrod
added a commit
that referenced
this issue
Jan 5, 2018
* Added a small internal/version package for parsing and comparing versions. * Added repo.FindExternalRepo, which locates the directory of an external repository. This will be used for indexing later. * Added checkRulesGoVersion which parses RULES_GO_VERSION out of def.bzl and compares it to a minimum. Fixes #51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With #48, Gazelle generates build files that depend on the
compilersattribute ofgo_proto_library, which was introduced after 0.8.1. We should check that the minimum version is at least 0.9.0.This should be checked in the
gazellerule (error) and in Gazelle itself (warning).The text was updated successfully, but these errors were encountered: