You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mergeExpr breaks an expression into a list and a dictionary (either of which may be empty) with exprListAndDict. This worked well before full multi-platform support was added, but now, generated expressions may have multiple select expressions, so this no longer works.
exprListAndDict will return an error when it encounters an expression it does not understand. When mergeRule gets this error, it will return the generated expression and discard the old expression, regardless of # keep comments.
Two things should be fixed:
exprListAndDict should be updated to handle expressions with generic, OS-specific, arch-specific, and platform-specific strings (it will need to inspect keys in select statements to do this). Each collection should be merged independently.
When exprListAndDict returns an error, mergeExpr should return the old expression if there are any # keep comments. Otherwise, it should return the generated expression. It should probably not return an error in any case.
The text was updated successfully, but these errors were encountered:
Gazelle can now merge expressions that contain multiple select
sub-expressions. Selects are identified as os-specific, arch-specific,
or platform-specific, based on the labels used in the select
dict. The dicts are merged independently.
Fixesbazelbuild#55
Gazelle can now merge expressions that contain multiple select
sub-expressions. Selects are identified as os-specific, arch-specific,
or platform-specific, based on the labels used in the select
dict. The dicts are merged independently.
Fixes#55
mergeExpr
breaks an expression into a list and a dictionary (either of which may be empty) withexprListAndDict
. This worked well before full multi-platform support was added, but now, generated expressions may have multipleselect
expressions, so this no longer works.exprListAndDict
will return an error when it encounters an expression it does not understand. WhenmergeRule
gets this error, it will return the generated expression and discard the old expression, regardless of# keep
comments.Two things should be fixed:
exprListAndDict
should be updated to handle expressions with generic, OS-specific, arch-specific, and platform-specific strings (it will need to inspect keys inselect
statements to do this). Each collection should be merged independently.exprListAndDict
returns an error,mergeExpr
should return the old expression if there are any# keep
comments. Otherwise, it should return the generated expression. It should probably not return an error in any case.The text was updated successfully, but these errors were encountered: